Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC silverstripe/widgets removed #283

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

emteknetnz
Copy link
Member

@@ -49,6 +50,10 @@ Read more about [eager loading](/developer_guides/model/relations/#eager-loading

- [`BuildTask`](api:SilverStripe\Dev\BuildTask) now has boolean `is_enabled` configuration option which has precedence over the existing `BuildTask::enabled` protected class property. The `BuildTask::enabled` property has been marked as deprecated and will be removed in CMS 6 if favour of using `is_enabled` instead.

## Dependency changes

- The unsupported module `silverstripe/widgets` was removed from `silverstripe/recipe-blog` after it was accidentally included in the `2.0.0` release of `silverstripe/recipe-blog`. If your project relies on `silverstripe/widgets` which is CMS 5 compatible though unsupported, you can still it to your project manually in your `composer.json` file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should mentioned both modules. Also, try to use simpler/shorter sentences where possible.

Suggested change
- The unsupported module `silverstripe/widgets` was removed from `silverstripe/recipe-blog` after it was accidentally included in the `2.0.0` release of `silverstripe/recipe-blog`. If your project relies on `silverstripe/widgets` which is CMS 5 compatible though unsupported, you can still it to your project manually in your `composer.json` file.
- The unsupported modules `silverstripe/widgets` and `silverstripe/content-widget` were removed from `silverstripe/recipe-blog`. They were accidentally included in the `2.0.0` release of `silverstripe/recipe-blog`. The `silverstripe/widgets` and `silverstripe/content-widget` modules are CMS-5-compatible though unsupported. If your project relies on `silverstripe/widgets` or `silverstripe/content-widget`, manually update your project's `composer.json` file to explicitly require these modules.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxime-rainville maxime-rainville merged commit e4e253a into silverstripe:5 Jun 12, 2023
@maxime-rainville maxime-rainville deleted the pulls/5/remove branch June 12, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants