FIX Attempt to require multiple versions of silverstripe/installer #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
changed the title
emteknetnz
force-pushed
the
pulls/1.1/multi-require
branch
from
c3839bc to
02421d2
Compare
GuySartorelli
requested changes
Jul 7, 2022
emteknetnz
force-pushed
the
pulls/1.1/multi-require
branch
3 times, most recently
from
b317cb9 to
a998f7f
Compare
emteknetnz
force-pushed
the
pulls/1.1/multi-require
branch
from
a998f7f to
cd50f73
Compare
GuySartorelli
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #11
Solve the issue where modules attempt to use an incompatible version of silverstripe/installer on push events. Example
https://github.com/creative-commoners/cwp-core/runs/7190501001?check_suite_focus=true
Example of this successfully falling back to use silverstripe/installer 4.10.x-dev after first failing with 4.11.x-dev
https://github.com/emteknetnz/cwp-core/runs/7228030181?check_suite_focus=true