-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX Add missing repo from hardcoded consts #37
FIX Add missing repo from hardcoded consts #37
Conversation
What if we ever wanted to remove a repo, we will get a warning until the last two sets have the same entries again? Not an urgent thing for now, may be never needed, just that we don't have a clear way of handling that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't test the warning mechanism, the consts file addition is legit. Merge at your convenience.
Running |
hardcoded.php
Outdated
if (!empty($missing)) { | ||
$formatColor = "\033[31m"; | ||
$endFormat = "\033[0m"; | ||
echo "\n" . $formatColor . 'Warning: The following modules were in the previous release but are missing in this release:' . $endFormat . "\n"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
echo "\n" . $formatColor . 'Warning: The following modules were in the previous release but are missing in this release:' . $endFormat . "\n"; | |
echo "\n" . $formatColor . 'Warning: The following modules were in the last release in INSTALLER_TO_REPO_MINOR_VERSIONS but are missing from .cow.pat.json:' . $endFormat . "\n"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making it really obvious where the issue is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
7b4c8ed
to
b39922b
Compare
This repo was missing in #36 because it's not in the cowpat.
I've also added a commit here which will help avoid similar mistakes in the future by calling out if repositories are missing which were present in the previous release.
IMPORTANT
The person who merges this should tag a new patch version immediately afterward
Parent issue