MNT Resolve CI problems #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
GuySartorelli
force-pushed
the
pulls/1.0/fix-ci
branch
2 times, most recently
from
7a32797
to
a125d4d
Compare
emteknetnz
requested changes
Nov 13, 2023
.env
Outdated
| @@ -0,0 +1,12 @@ | |||
| SS_DATABASE_CLASS="MySQLDatabase" | |||
There was a problem hiding this comment.
Shouldn't be adding a .env file directly in root of a module
We dynamically create .env file in ci - https://github.com/silverstripe/gha-ci/blob/1/.github/workflows/ci.yml#L657 - may need to make an update in gha-ci to get this to work the way you want things to?
There was a problem hiding this comment.
Oops, that was just a git add . and not double checking if I was adding extra gunk. It's a directly copy of what CI adds already from when I was trying to figure out what was going wrong in CI.
GuySartorelli
force-pushed
the
pulls/1.0/fix-ci
branch
from
a125d4d
to
bd9ca57
Compare
emteknetnz
requested changes
Nov 13, 2023
- Tell phpcs what to sniff - Throw a hard error if we can't bootstrap tests correctly - Force Tokens.php to be run for constant declarations
GuySartorelli
force-pushed
the
pulls/1.0/fix-ci
branch
from
bd9ca57
to
17757eb
Compare
|
@emteknetnz Are there any more changes needed for this PR? |
emteknetnz
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linting and unit tests are failing - see https://github.com/silverstripe/markdown-php-codesniffer/actions/runs/6844025973
Tokens.phpto be run for constant declarations (needed in CI for some reason, but not needed locally)Issue