Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Add brackets #49

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented May 16, 2024

Turns out you need brackets in this scenario, won't return a bool, instead it returns the value of the property

$o = new stdClass;
$o->abc=123;
var_dump($o->abc ?? '' === 'def');
// int(123)

Also alpha sorts script files so that scripts run in a predictable nature - this is desirable because there's a depedency on dispatch-ci.yml from merge-ups.yml - https://github.com/silverstripe/module-standardiser/blob/main/scripts/cms-any/merge-ups.php#L10

README.md Show resolved Hide resolved
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alphabetical order probably isn't best when we are doing it because some scripts depend on others - but until we add additional inter-dependencies it'll do well enough.

@GuySartorelli GuySartorelli merged commit e49b9d8 into silverstripe:main May 16, 2024
1 check passed
@GuySartorelli GuySartorelli deleted the pulls/main/brackets branch May 16, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants