Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEP 4.10 requirements #22

Merged
merged 1 commit into from
Dec 3, 2021
Merged

DEP 4.10 requirements #22

merged 1 commit into from
Dec 3, 2021

Conversation

emteknetnz
Copy link
Member

maxime-rainville
maxime-rainville requested changes Dec 2, 2021
View reviewed changes
Copy link

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds are failing. Doesn't look like it's related to this.

Do we want to merge as is and deal with the failure in a separate PR?

@emteknetnz
Copy link
Member Author

yup, unrelated, should merge

maxime-rainville
maxime-rainville approved these changes Dec 3, 2021
View reviewed changes
Copy link

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved despite failing build. Will create a an issue to solve broken build

@maxime-rainville maxime-rainville merged commit e8a8c7e into silverstripe:1.10 Dec 3, 2021
@maxime-rainville maxime-rainville deleted the pulls/1.10/deps branch December 3, 2021 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxime-rainville maxime-rainville maxime-rainville approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @maxime-rainville