Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH CMS 6 branch support #12

Merged
merged 1 commit into from
Feb 22, 2024
Merged

ENH CMS 6 branch support #12

merged 1 commit into from
Feb 22, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz mentioned this pull request Feb 19, 2024
Closed
6 tasks
@emteknetnz emteknetnz force-pushed the pulls/main/cms6 branch 2 times, most recently from f41f675 to 7491dee Compare February 20, 2024 05:47
@GuySartorelli GuySartorelli mentioned this pull request Feb 20, 2024
Closed
1 task
GuySartorelli
GuySartorelli requested changes Feb 20, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like there's a lot of duplicated code - but probably tidying that up is out of scope since you're adding onto already-duplicated code.

One question below.

app/src/Processors/BuildsProcessor.php Outdated Show resolved Hide resolved
@GuySartorelli
Copy link
Member

merge ups tab is getting silly.
PRobably worth removing all of the Url columns, and just put the link directly in the Mu column (i.e. any time it says "needs-merge-up" just make that a link, so we have one less column for each branch.

@emteknetnz
Copy link
Member Author

Have combined the mu and cmp columns, much nicer now

@emteknetnz emteknetnz force-pushed the pulls/main/cms6 branch 2 times, most recently from 2eaf9b8 to 3d8d94b Compare February 21, 2024 00:42
GuySartorelli
GuySartorelli approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, loving the cleaner mergeups tab.

@GuySartorelli GuySartorelli merged commit 2aba885 into main Feb 22, 2024
@GuySartorelli GuySartorelli deleted the pulls/main/cms6 branch February 22, 2024 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli