API Standardise extension hooks (#1810)

silverstripe · Aug 27, 2024 · 1c18c90 · 1c18c90
1 parent 3e51244
commit 1c18c90
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 6 deletions.
diff --git a/code/LeftAndMain.php b/code/LeftAndMain.php
@@ -784,7 +784,7 @@ protected function init()
             }
         }
 
-        $this->extend('init');
+        $this->extend('onInit');
 
         // Load the editor with original user themes before overwriting
         // them with admin themes

diff --git a/code/LeftAndMainExtension.php b/code/LeftAndMainExtension.php
@@ -26,7 +26,7 @@ public function __construct()
         parent::__construct();
     }
 
-    public function init()
+    protected function onInit()
     {
     }
 

diff --git a/tests/behat/src/Extension/CannotCreateExtension.php b/tests/behat/src/Extension/CannotCreateExtension.php
@@ -7,7 +7,7 @@
 
 class CannotCreateExtension extends Extension implements TestOnly
 {
-    public function canCreate()
+    protected function canCreate()
     {
         return false;
     }

diff --git a/tests/behat/src/Extension/CannotDeleteExtension.php b/tests/behat/src/Extension/CannotDeleteExtension.php
@@ -7,7 +7,7 @@
 
 class CannotDeleteExtension extends Extension implements TestOnly
 {
-    public function canDelete()
+    protected function canDelete()
     {
         return false;
     }

diff --git a/tests/behat/src/Extension/CannotEditExtension.php b/tests/behat/src/Extension/CannotEditExtension.php
@@ -7,7 +7,7 @@
 
 class CannotEditExtension extends Extension implements TestOnly
 {
-    public function canEdit()
+    protected function canEdit()
     {
         return false;
     }

diff --git a/tests/php/CMSProfileControllerTest/TestExtension.php b/tests/php/CMSProfileControllerTest/TestExtension.php
@@ -6,7 +6,7 @@
 
 class TestExtension extends DataExtension
 {
-    public function canEdit($member = null)
+    protected function canEdit($member = null)
     {
         return false;
     }