TLN Update translations #1617
Merged
TLN Update translations #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
requested changes
Nov 5, 2023
lang/en.yml
Outdated
| 'PREVIEW''': Preview | ||
| "PREVIEW'": Preview |
There was a problem hiding this comment.
We should remove the random apostrophe instead. I'm assuming it's in the php code somewhere.
Suggested change
| 'PREVIEW''': Preview | |
| "PREVIEW'": Preview | |
| PREVIEW: Preview |
There was a problem hiding this comment.
Have removed key, we don't normally allow this though there is a valid PREVIEW key above it and given this is a new entry for 2.0 (was migrated from a different class in 1.13) I don't think this will cause any translation regressions. The latest patch release for 2.0 uses the correct 'PREVIEW' key
emteknetnz
force-pushed
the
pulls/2/tx-1698976230
branch
from
441d2d3
to
9463da4
Compare
GuySartorelli
approved these changes
Nov 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated translations update generated using silverstripe/tx-translator