Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP Update validator js dep to fix date validation bug #1775

Conversation

GuySartorelli
Copy link
Member

Description

Fixes a bug which marks valid dates as invalid in a react form.

Manual testing steps

  1. Set your location or timezone in your browser to something in america or canada (I used this guide and set mine to the built in "San Francisco" location)
  2. Follow the reproduction steps in the linked issue

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release not needed
  • CI is green

@GuySartorelli
Copy link
Member Author

@UndefinedOffset can you please check if this PR fixes the bug for you?

@GuySartorelli
Copy link
Member Author

CI failure is unrelated - it's already happening on that branch. See https://github.com/silverstripe/silverstripe-admin/actions/runs/9311752943.

That'll be fixed in silverstripe/.github#266

@UndefinedOffset
Copy link

UndefinedOffset commented Jun 10, 2024

@GuySartorelli that does fix it for me, I asked a couple of the other guys on our team and they also no longer see the issue :)

@emteknetnz emteknetnz merged commit df02655 into silverstripe:2.2 Jun 10, 2024
10 of 12 checks passed
@emteknetnz emteknetnz deleted the pulls/2.2/update-js-dep-validator branch June 10, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants