New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Fix behat failure #1776

Merged

emteknetnz merged 1 commit into silverstripe:2.2 from creative-commoners:pulls/2.2/fix-behat

Jun 11, 2024

Member

GuySartorelli commented Jun 11, 2024 •

edited

Loading

Fixes https://github.com/silverstripe/silverstripe-admin/actions/runs/9456664685/job/26049017215

Scenario: I can see tab validation icons on multi-tab pages # tests/behat/features/multitab-validation.feature:12
Then I can see the form validation error message # SilverStripe\Admin\Tests\Behat\Context\AdminContext::iCanSeeTheFormValidationErrorMessage()

Element #Form_EditForm_error not found
Failed asserting that false is true.

The failure was caused by silverstripe/silverstripe-frameworktest#180 which was for a change in admin on branch 2: #1751

This PR updates the behat tests for 2.2 to account for the change to frameworktest.

Issue

Broken builds and merge-ups .github#266


          MNT Fix behat failure

fc31a83

GuySartorelli mentioned this pull request

Broken builds and merge-ups silverstripe/.github#266

Closed

emteknetnz approved these changes

View reviewed changes

emteknetnz merged commit 17a4e1f into silverstripe:2.2

12 checks passed

emteknetnz deleted the pulls/2.2/fix-behat branch

June 11, 2024 04:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet