Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADD / After each step we wait for the server to handle all requests #185

Merged
merged 1 commit into from
Jan 8, 2019
Merged

ADD / After each step we wait for the server to handle all requests #185

merged 1 commit into from
Jan 8, 2019

Conversation

dnsl48
Copy link

@dnsl48 dnsl48 commented Dec 19, 2018 •
edited
Loading

This was referenced Dec 19, 2018
Closed
Merged
maxime-rainville
maxime-rainville approved these changes Jan 8, 2019
View reviewed changes
Copy link

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I tested the message gets displayed properly by hacking waitForPendingRequests to always return false.

@maxime-rainville maxime-rainville merged commit f02fd0c into silverstripe:4.0 Jan 8, 2019
@maxime-rainville maxime-rainville deleted the pulls/4.0/afterstep-wait-responses branch January 8, 2019 04:52
@maxime-rainville maxime-rainville mentioned this pull request Jan 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbieaverill robbieaverill robbieaverill left review comments

@maxime-rainville maxime-rainville maxime-rainville approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dnsl48 @maxime-rainville @robbieaverill