Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API phpunit9 support #205

Merged
merged 1 commit into from
Oct 27, 2021
Merged

API phpunit9 support #205

merged 1 commit into from
Oct 27, 2021

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz marked this pull request as draft October 12, 2021 23:05
@emteknetnz emteknetnz mentioned this pull request Oct 12, 2021
Closed
93 tasks
@emteknetnz emteknetnz force-pushed the pulls/4/sapphire-test-nine branch 7 times, most recently from 9349063 to f019c25 Compare October 19, 2021 21:28
@emteknetnz emteknetnz marked this pull request as ready for review October 22, 2021 00:59
maxime-rainville
maxime-rainville approved these changes Oct 27, 2021
View reviewed changes
Copy link

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's maybe bump the PHP requirement. Good otherwise.

composer.json Outdated
@@ -22,15 +22,15 @@
],
"require": {
"php": ">=5.6",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"php": ">=5.6",
"php": ">=7.3",

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@emteknetnz emteknetnz force-pushed the pulls/4/sapphire-test-nine branch from f019c25 to 461e7fa Compare October 27, 2021 04:14
@emteknetnz emteknetnz force-pushed the pulls/4/sapphire-test-nine branch from 461e7fa to 9ee6858 Compare October 27, 2021 04:14
@maxime-rainville maxime-rainville merged commit 6ccf840 into silverstripe:4 Oct 27, 2021
@maxime-rainville maxime-rainville deleted the pulls/4/sapphire-test-nine branch October 27, 2021 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxime-rainville maxime-rainville maxime-rainville approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @maxime-rainville