ENH PHP 8.1 compatibility #212
Conversation
emteknetnz
force-pushed
the
pulls/4/php81
branch
from
6481f65 to
1f9fc6d
Compare
| if (trim($negate)) { | ||
| if (preg_match($regex, $actual)) { | ||
| if (trim($negate ?? '')) { | ||
| if (preg_match($regex ?? '', $actual ?? '')) { |
There was a problem hiding this comment.
| if (preg_match($regex ?? '', $actual ?? '')) { | |
| if (preg_match($regex ?? '//', $actual ?? '')) { |
There was a problem hiding this comment.
This was discussed in another PR - the warning emitted by the empty string is correct and we would be hiding an actual issue by using an empty regex. The intention here is just to avoid deprecation warnings.
There was a problem hiding this comment.
For posterity: See discussion in silverstripe/silverstripe-admin#1294 about the general approach. tl;dr:
the purposes of this PR is to avoid passing null (specifically null) from built-in functions that as of php 8.1 will throw deprecation warnings if null is passed in. The approach is necessarily heavy-handed, and while there are many situations where it isn't needed, it would be prohibitively laborious to find all of those situations by hand.
Looks good to me
Issue silverstripe/silverstripe-framework#10250