FIX Don't use the deprecated 'none' encryptor #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
requested changes
May 24, 2024
|
Sink seems excessive, I'd have thought installer maybe. But to avoid ping pong I'll just do it with all of sink. Link to CI run will be in the linked issue description. |
GuySartorelli
commented
May 28, 2024
Comment on lines
317
to
+323
| // make sure any validation for password is skipped, since we're not testing complexity here | ||
| $validator = Member::password_validator(); | ||
| Member::set_password_validator(null); | ||
| $nullValidator = new PasswordValidator(); | ||
| $nullValidator->setMinLength(0); | ||
| $nullValidator->setMinTestScore(0); | ||
| $nullValidator->setHistoricCount(0); | ||
| Member::set_password_validator($nullValidator); |
There was a problem hiding this comment.
Without this change, we get this error:
You've already used that password in the past, please choose a new password
The comment makes it clear this was the intention here.
Outside of testing I can't see any reason to not have a member password validator, and the current behaviour is when null is passed in the result is the default password validator is instantiated which IMO is good behaviour.
GuySartorelli
commented
May 28, 2024
| $member->FirstName = $identifier; | ||
| $member->Surname = "User"; | ||
| $member->Email = $email; | ||
| $member->PasswordEncryption = "none"; |
There was a problem hiding this comment.
This is the main change for this PR - anything else is done to support this change.
emteknetnz
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting a Member's
PasswordEncryptionto "none" ends up using the deprecatedPasswordEncryptor_Noneclass.There's no reason to not use encryption here.
Issue
PasswordEncryptor_Nonewhen creating new users #271