Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Fix github action for deploying userdocs #1000

Merged

Conversation

GuySartorelli
Copy link
Member

Set the branches that activate the action to match the ones used by userhelp according to the userhelp sources json

Also more clearly and accurately identify the specific action (main.yml is hardly specific).

Parent Issue

@GuySartorelli
Copy link
Member Author

The scrutinizer failure can be ignored for this PR - we don't use it anymore, and it will be removed as a part of https://github.com/silverstripeltd/product-issues/issues/567

Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory, if any of the repos are updated the user help should be rebuilt. Would it make more sense to build this on a cron instead?

@GuySartorelli
Copy link
Member Author

In theory, if any of the repos are updated the user help should be rebuilt. Would it make more sense to build this on a cron instead?

maybe? I don't think either approach is really more-or-less valuable than the other.
The current approach means it only gets rebuilt when there are actually changes to make - but it might result in rebuilding the site multiple times in quick succession for weird situations where we find multiple related issues.

A cron approach would mean we rebuild unnecessarily a lot (userdocs are not updated frequently at all) but would mean we don't have to worry about adding and updating these actions anywhere that userdocs sit.

I can see some value in both approaches but I don't think there is enough value in the cron approach to warrant changing it right this very second. Maybe create a new issue for that if you think it's worthwhile?

@maxime-rainville maxime-rainville merged commit 1765655 into silverstripe:4 Aug 22, 2022
@maxime-rainville maxime-rainville deleted the pulls/4/fix-userdoc-deploy branch August 22, 2022 22:25
menno-rdmkr pushed a commit to busting-bytes/silverstripe-elemental that referenced this pull request Dec 15, 2022
…fix-userdoc-deploy

MNT Fix github action for deploying userdocs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants