-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH add config for allowed_error_codes #91
Merged
GuySartorelli
merged 1 commit into
silverstripe:2
from
andrewandante:ENH/error_codes_as_config
Sep 26, 2023
Merged
ENH add config for allowed_error_codes #91
GuySartorelli
merged 1 commit into
silverstripe:2
from
andrewandante:ENH/error_codes_as_config
Sep 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewandante
force-pushed
the
ENH/error_codes_as_config
branch
from
September 25, 2023 04:02
85f05da
to
c597b69
Compare
andrewandante
force-pushed
the
ENH/error_codes_as_config
branch
3 times, most recently
from
September 25, 2023 20:22
5493817
to
31acfea
Compare
GuySartorelli
requested changes
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Some requested changes below.
andrewandante
force-pushed
the
ENH/error_codes_as_config
branch
from
September 25, 2023 22:33
31acfea
to
5a88a52
Compare
andrewandante
force-pushed
the
ENH/error_codes_as_config
branch
from
September 25, 2023 22:45
5a88a52
to
7783956
Compare
andrewandante
force-pushed
the
ENH/error_codes_as_config
branch
from
September 25, 2023 22:51
7783956
to
b4f0088
Compare
GuySartorelli
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Works exactly as expected. Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90
Allows configuration of error codes for the dropdown via
allowed_error_codes
config var.Docs PR: silverstripe/developer-docs#352