Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH add config for allowed_error_codes #91

Merged

Conversation

andrewandante
Copy link
Contributor

@andrewandante andrewandante commented Sep 25, 2023

Fixes #90

Allows configuration of error codes for the dropdown via allowed_error_codes config var.

Docs PR: silverstripe/developer-docs#352

@andrewandante andrewandante force-pushed the ENH/error_codes_as_config branch from 85f05da to c597b69 Compare September 25, 2023 04:02
@andrewandante andrewandante force-pushed the ENH/error_codes_as_config branch 3 times, most recently from 5493817 to 31acfea Compare September 25, 2023 20:22
@andrewandante andrewandante marked this pull request as ready for review September 25, 2023 20:26
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Some requested changes below.

README.md Outdated Show resolved Hide resolved
src/ErrorPage.php Show resolved Hide resolved
src/ErrorPage.php Outdated Show resolved Hide resolved
src/ErrorPage.php Outdated Show resolved Hide resolved
tests/ErrorPageTest.php Outdated Show resolved Hide resolved
tests/Fake/FakeErrorPage.php Outdated Show resolved Hide resolved
tests/ErrorPageTest.yml Outdated Show resolved Hide resolved
@andrewandante andrewandante force-pushed the ENH/error_codes_as_config branch from 31acfea to 5a88a52 Compare September 25, 2023 22:33
@andrewandante andrewandante force-pushed the ENH/error_codes_as_config branch from 7783956 to b4f0088 Compare September 25, 2023 22:51
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Works exactly as expected. Thank you.

@GuySartorelli GuySartorelli merged commit 949d48b into silverstripe:2 Sep 26, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make dropdown of error codes configurable in yaml
2 participants