API Remove deprecated code

.upgrade.yml

@@ -176,8 +176,6 @@ mappings:
   SS_ClassManifest: SilverStripe\Core\Manifest\ClassManifest
   SilverStripe\Core\Manifest\SS_ClassManifest: SilverStripe\Core\Manifest\ClassManifest
   ManifestFileFinder: SilverStripe\Core\Manifest\ManifestFileFinder
-  ErrorControlChain: SilverStripe\Core\Startup\ErrorControlChain
-  ParameterConfirmationToken: SilverStripe\Core\Startup\ParameterConfirmationToken
   DatabaseAdapterRegistry: SilverStripe\Dev\Install\DatabaseAdapterRegistry
   DatabaseConfigurationHelper: SilverStripe\Dev\Install\DatabaseConfigurationHelper
   MySQLDatabaseConfigurationHelper: SilverStripe\Dev\Install\MySQLDatabaseConfigurationHelper
@@ -192,7 +190,6 @@ mappings:
   CliDebugView: SilverStripe\Dev\CliDebugView
   CSSContentParser: SilverStripe\Dev\CSSContentParser
   CsvBulkLoader: SilverStripe\Dev\CsvBulkLoader
-  CSVParser: SilverStripe\Dev\CSVParser
   Debug: SilverStripe\Dev\Debug
   DebugView: SilverStripe\Dev\DebugView
   Deprecation: SilverStripe\Dev\Deprecation
@@ -201,7 +198,6 @@ mappings:
   FixtureBlueprint: SilverStripe\Dev\FixtureBlueprint
   FixtureFactory: SilverStripe\Dev\FixtureFactory
   FunctionalTest: SilverStripe\Dev\FunctionalTest
-  InstallerTest: SilverStripe\Dev\InstallerTest
   MigrationTask: SilverStripe\Dev\MigrationTask
   SapphireTest: SilverStripe\Dev\SapphireTest
   TaskRunner: SilverStripe\Dev\TaskRunner
@@ -229,17 +225,13 @@ mappings:
   NestedController: SilverStripe\Control\NestedController
   NullHTTPRequest: SilverStripe\Control\NullHTTPRequest
   PjaxResponseNegotiator: SilverStripe\Control\PjaxResponseNegotiator
-  RequestFilter: SilverStripe\Control\RequestFilter
   RequestHandler: SilverStripe\Control\RequestHandler
-  RequestProcessor: SilverStripe\Control\RequestProcessor
   Session: SilverStripe\Control\Session
   Email: SilverStripe\Control\Email\Email
-  Mailer: SilverStripe\Control\Email\Mailer
   RSSFeed: SilverStripe\Control\RSS\RSSFeed
   RSSFeed_Entry: SilverStripe\Control\RSS\RSSFeed_Entry
   CleanupTestDatabasesTask: SilverStripe\Dev\Tasks\CleanupTestDatabasesTask
   i18nTextCollectorTask: SilverStripe\Dev\Tasks\i18nTextCollectorTask
-  MigrateFileTask: SilverStripe\Dev\Tasks\MigrateFileTask
   CheckboxField: SilverStripe\Forms\CheckboxField
   CheckboxField_Readonly: SilverStripe\Forms\CheckboxField_Readonly
   CheckboxSetField: SilverStripe\Forms\CheckboxSetField
@@ -372,7 +364,6 @@ mappings:
   GenericTemplateGlobalProvider: SilverStripe\View\GenericTemplateGlobalProvider
   Requirements: SilverStripe\View\Requirements
   Requirements_Backend: SilverStripe\View\Requirements_Backend
-  Requirements_Minifier: SilverStripe\View\Requirements_Minifier
   SSTemplateParseException: SilverStripe\View\SSTemplateParseException
   SSTemplateParser: SilverStripe\View\SSTemplateParser
   SSViewer_Scope: SilverStripe\View\SSViewer_Scope
@@ -487,7 +478,6 @@ mappings:
   CsvBulkLoaderTest_Team: SilverStripe\Dev\Tests\CsvBulkLoaderTest\Team
   CsvBulkLoaderTest_Player: SilverStripe\Dev\Tests\CsvBulkLoaderTest\Player
   CsvBulkLoaderTest_PlayerContract: SilverStripe\Dev\Tests\CsvBulkLoaderTest\PlayerContract
-  CSVParserTest: SilverStripe\Dev\Tests\CSVParserTest
   DeprecationTest_Deprecation: SilverStripe\Dev\Tests\DeprecationTest\TestDeprecation
   DeprecationTest: SilverStripe\Dev\Tests\DeprecationTest
   DevAdminControllerTest: SilverStripe\Dev\Tests\DevAdminControllerTest
@@ -847,11 +837,6 @@ mappings:
   ThemeResourceLoaderTest: SilverStripe\Core\Tests\Manifest\ThemeResourceLoaderTest
   EmailTest: SilverStripe\Control\Tests\Email\EmailTest
   MailerTest: SilverStripe\Control\Tests\Email\SwiftMailerTest
-  ErrorControlChainTest_Chain: SilverStripe\Core\Tests\Startup\ErrorControlChainTest\ErrorControlChainTest_Chain
-  ErrorControlChainTest: SilverStripe\Core\Tests\Startup\ErrorControlChainTest
-  ParameterConfirmationTokenTest_Token: SilverStripe\Core\Tests\Startup\ParameterConfirmationTokenTest\ParameterConfirmationTokenTest_Token
-  ParameterConfirmationTokenTest_ValidToken: SilverStripe\Core\Tests\Startup\ParameterConfirmationTokenTest\ParameterConfirmationTokenTest_ValidToken
-  ParameterConfirmationTokenTest: SilverStripe\Core\Tests\Startup\ParameterConfirmationTokenTest
   ConfigTest_DefinesFoo: SilverStripe\Core\Tests\Config\ConfigTest\DefinesFoo
   ConfigTest_DefinesBar: SilverStripe\Core\Tests\Config\ConfigTest\DefinesBar
   ConfigTest_DefinesFooAndBar: SilverStripe\Core\Tests\Config\ConfigTest\DefinesFooAndBar
@@ -981,8 +966,6 @@ warnings:
       message: 'Renamed to CMSMain_TreeNode'
     'HTMLEditorField_Toolbar':
       message: 'replaced With SilverStripe\Admin\ModalController'
-    'HTMLEditorField_Embed':
-      message: 'replaced with SilverStripe\View\Embed\EmbedResource'
     'HTMLEditorField_File':
       message: 'Removed'
     'HTMLEditorField_Flash':
@@ -1009,14 +992,8 @@ warnings:
       message: 'Use SilverStripe\CMS\BatchActions\CMSBatchAction_Archive instead'
     'EncryptAllPasswordsTask':
       message: 'Removed'
-    'SapphireInfo':
-      message: 'Removed'
     'SilverStripe\Dev\SapphireREPL':
       message: 'Removed'
-    'SilverStripe\Dev\SapphireInfo':
-      message: 'Deprecated'
-    'SilverStripe\Dev\InstallerTest':
-      message: 'Deprecated'
   methods:
     'SilverStripe\Security\Authenticator::register()':
       message: 'Custom authenticators work differently now'
@@ -1309,12 +1286,6 @@ warnings:
       message: 'Removed SilverStripe\ORM\FieldType\DBDate->day_before()'
     'days_between()':
       message: 'Removed SilverStripe\ORM\FieldType\DBDate->days_between()'
-    'SilverStripe\Security\Permission::get_declared_permissions_list()':
-      message: 'Deprecated'
-    'SilverStripe\Security\Permission::get_label_for_permission()':
-      message: 'Deprecated'
-    'SilverStripe\Security\Permission::traverse_declared_permissions()':
-      message: 'Deprecated'
     'SilverStripe\Control\Session::get_all()':
       message: 'Session can not be accessed statically and `get_all()` is now called `getAll()'
     'SilverStripe\Control\Session::clear_all()':
@@ -1350,12 +1321,6 @@ warnings:
       replacement: 'writeJavascriptToBody'
     'SilverStripe\Forms\Formfield->dontEscape':
       message: 'FormField::$dontEscape has been removed. Escaping is now managed on a class by class basis.'
-    'SilverStripe\Security\LoginForm->authenticator_class':
-      message: 'authenticator_class is deprecated. Use getAuthenticatorClass/setAuthenticatorClass.'
-    'SilverStripe\Security\Permission->declared_permissions':
-      message: 'Deprecated'
-    'SilverStripe\Security\Permission->declared_permissions_list':
-      message: 'Deprecated'
   functions:
     'file_get_contents()':
       message: 'Use new asset abstraction'
@@ -1428,8 +1393,6 @@ visibilities:
     visibility: private
   'SilverStripe\ORM\DataObject::default_classname':
     visibility: private
-  'SilverStripe\ORM\DataObject->destroyed':
-    visibility: public
   'SilverStripe\ORM\DataObject->record':
     visibility: protected
   'SilverStripe\ORM\DataObject->joinRecord':

_config/backtrace.yml

@@ -12,9 +12,6 @@ SilverStripe\Dev\Backtrace:
     - ['SilverStripe\Control\Middleware\ConfirmationMiddleware\GetParameter', buildConfirmationItem]
     - ['SilverStripe\Control\Middleware\ConfirmationMiddleware\Url', buildConfirmationItem]
     - ['SilverStripe\Control\Middleware\ConfirmationMiddleware\UrlPathStartswith', buildConfirmationItem]
-    - ['SilverStripe\Core\Startup\AbstractConfirmationToken', 'checkToken']
-    - ['SilverStripe\Core\Startup\AbstractConfirmationToken', 'pathForToken']
-    - ['SilverStripe\Core\Startup\AbstractConfirmationToken', 'prepare_tokens']
     - ['SilverStripe\ORM\DB', 'connect']
     - ['SilverStripe\ORM\DB', 'createDatabase']
     - ['SilverStripe\Security\Confirmation\Item', '__construct']
@@ -33,9 +30,7 @@ SilverStripe\Dev\Backtrace:
     - ['SilverStripe\Security\PasswordEncryptor_Blowfish', 'encryptY']
     - ['SilverStripe\Security\PasswordValidator', 'validate']
     - ['SilverStripe\Security\RememberLoginHash', 'setToken']
-    - ['SilverStripe\Security\Security', 'check_default_admin']
     - ['SilverStripe\Security\Security', 'encrypt_password']
-    - ['SilverStripe\Security\Security', 'setDefaultAdmin']
     - ['*', 'checkPassword']
     - ['*', 'onAfterChangePassword']
     - ['*', 'onBeforeChangePassword']

_config/requestprocessors.yml

@@ -3,13 +3,12 @@ Name: requestprocessors
 ---
 SilverStripe\Core\Injector\Injector:
   SilverStripe\Control\Director:
-    # Note: Don't add 'class' config here, as it will affect ErrorDirector as well
+    # Note: Don't add 'class' config here
     properties:
       Middlewares:
         TrustedProxyMiddleware: '%$SilverStripe\Control\Middleware\TrustedProxyMiddleware'
         AllowedHostsMiddleware: '%$SilverStripe\Control\Middleware\AllowedHostsMiddleware'
         SessionMiddleware: '%$SilverStripe\Control\Middleware\SessionMiddleware'
-        RequestProcessorMiddleware: '%$SilverStripe\Control\RequestProcessor'
         FlushMiddleware: '%$SilverStripe\Control\Middleware\FlushMiddleware'
         ChangeDetectionMiddleware: '%$SilverStripe\Control\Middleware\ChangeDetectionMiddleware'
         HTTPCacheControleMiddleware: '%$SilverStripe\Control\Middleware\HTTPCacheControlMiddleware'
@@ -33,16 +32,6 @@ SilverStripe\Core\Injector\Injector:
       Middlewares:
         - '%$SecurityRateLimitMiddleware'
 
----
-Name: errorrequestprocessors
-After:
-  - '#requestprocessors'
----
-SilverStripe\Core\Injector\Injector:
-  # Note: If Director config changes, take note it will affect this config too
-  SilverStripe\Core\Startup\ErrorDirector: '%$SilverStripe\Control\Director'
-
-
 ---
 Name: canonicalurls
 ---

lang/bg.yml

@@ -16,9 +16,6 @@ bg:
     TEXT1: 'Това е Вашият'
     TEXT2: 'адрес за нулиране на парола'
     TEXT3: за
-  SilverStripe\Control\RequestProcessor:
-    INVALID_REQUEST: 'Грешна заявка'
-    REQUEST_ABORTED: 'Заявката беше отказана'
   SilverStripe\Forms\CheckboxField:
     NOANSWER: Не
     YESANSWER: Да

lang/da.yml

@@ -16,9 +16,6 @@ da:
     TEXT1: 'Her er din'
     TEXT2: 'link til at nulstille dit kodeord'
     TEXT3: for
-  SilverStripe\Control\RequestProcessor:
-    INVALID_REQUEST: 'Ugyldig forespørgsel'
-    REQUEST_ABORTED: 'Forespørgsel annulleret'
   SilverStripe\Forms\CheckboxField:
     NOANSWER: Nej
     YESANSWER: Ja

lang/de.yml

@@ -24,9 +24,6 @@ de:
   SilverStripe\Control\Middleware\ConfirmationMiddleware\UrlPathStartswith:
     CONFIRMATION_DESCRIPTION: 'Die komplette URL ist: "{url}"'
     CONFIRMATION_NAME: 'URL beginnt mit "{path}"'
-  SilverStripe\Control\RequestProcessor:
-    INVALID_REQUEST: 'Ungültige Anfrage'
-    REQUEST_ABORTED: 'Anfrage abgebrochen'
   SilverStripe\Dev\DevConfirmationController:
     INFO_DESCRIPTION: 'Bestätige potenziell gefährliche Aktion'
     INFO_TITLE: Sicherheitsbestätigung

lang/en.yml

@@ -22,9 +22,6 @@ en:
   SilverStripe\Control\Middleware\ConfirmationMiddleware\UrlPathStartswith:
     CONFIRMATION_DESCRIPTION: 'The complete URL is: "{url}"'
     CONFIRMATION_NAME: 'URL begins with "{path}"'
-  SilverStripe\Control\RequestProcessor:
-    INVALID_REQUEST: 'Invalid request'
-    REQUEST_ABORTED: 'Request aborted'
   SilverStripe\Dev\DevConfirmationController:
     INFO_DESCRIPTION: 'Confirm potentially dangerous operation'
     INFO_TITLE: 'Security Confirmation'

lang/eo.yml

@@ -24,9 +24,6 @@ eo:
   SilverStripe\Control\Middleware\ConfirmationMiddleware\UrlPathStartswith:
     CONFIRMATION_DESCRIPTION: 'La tuta URL estas: "{url}"'
     CONFIRMATION_NAME: 'URL komenciĝas per "{path}"'
-  SilverStripe\Control\RequestProcessor:
-    INVALID_REQUEST: 'Malvalida peto'
-    REQUEST_ABORTED: 'Ĉesigis peton'
   SilverStripe\Dev\DevConfirmationController:
     INFO_DESCRIPTION: 'Konfirmi eble danĝeran operacion'
     INFO_TITLE: 'Sekurecon konfirmi'

lang/fi.yml

@@ -16,9 +16,6 @@ fi:
     TEXT1: 'Tässä sinun'
     TEXT2: 'salasanasi palautuslinkki'
     TEXT3: henkilölle
-  SilverStripe\Control\RequestProcessor:
-    INVALID_REQUEST: 'Pyyntö on virheellinen'
-    REQUEST_ABORTED: 'Pyyntö keskeytetty'
   SilverStripe\Forms\CheckboxField:
     NOANSWER: Ei
     YESANSWER: Kyllä

lang/fi_FI.yml

@@ -24,9 +24,6 @@ fi_FI:
   SilverStripe\Control\Middleware\ConfirmationMiddleware\UrlPathStartswith:
     CONFIRMATION_DESCRIPTION: 'Kokonainen URL-osoite on: "{url}"'
     CONFIRMATION_NAME: 'URL alkaa "{path}"'
-  SilverStripe\Control\RequestProcessor:
-    INVALID_REQUEST: 'Pyyntö on virheellinen'
-    REQUEST_ABORTED: 'Pyyntö keskeytetty'
   SilverStripe\Dev\DevConfirmationController:
     INFO_DESCRIPTION: 'Vahvista mahdollisesti kohtalokas toimenpide'
     INFO_TITLE: Suojausvahvistus

lang/fr.yml

@@ -16,9 +16,6 @@ fr:
     TEXT1: 'Voici votre'
     TEXT2: 'Lien de réinitialisation de mot de passe'
     TEXT3: pour
-  SilverStripe\Control\RequestProcessor:
-    INVALID_REQUEST: 'Requête invalide'
-    REQUEST_ABORTED: 'Requête non aboutie'
   SilverStripe\Forms\CheckboxField:
     NOANSWER: Non
     YESANSWER: Oui

lang/it.yml

@@ -24,9 +24,6 @@ it:
   SilverStripe\Control\Middleware\ConfirmationMiddleware\UrlPathStartswith:
     CONFIRMATION_DESCRIPTION: 'L''URL completo è: "{url}"'
     CONFIRMATION_NAME: 'L''URL comincia con "{path}"'
-  SilverStripe\Control\RequestProcessor:
-    INVALID_REQUEST: 'Richiesta non valida'
-    REQUEST_ABORTED: 'Richiesta annullata'
   SilverStripe\Dev\DevConfirmationController:
     INFO_DESCRIPTION: 'Confermare l''operazione potenzialmente pericolosa'
     INFO_TITLE: 'Conferma di Sicurezza'

lang/nl.yml

@@ -24,9 +24,6 @@ nl:
   SilverStripe\Control\Middleware\ConfirmationMiddleware\UrlPathStartswith:
     CONFIRMATION_DESCRIPTION: 'De volledige URL is: "{url}"'
     CONFIRMATION_NAME: 'De URL begint met "{path}"'
-  SilverStripe\Control\RequestProcessor:
-    INVALID_REQUEST: 'Fout bij verwerken'
-    REQUEST_ABORTED: 'Fout bij verwerken (geannuleerd)'
   SilverStripe\Dev\DevConfirmationController:
     INFO_DESCRIPTION: 'Bevestig het uitvoeren van mogelijk gevaarlijke taak'
     INFO_TITLE: Beveiligingswaarschuwing

lang/pl.yml

@@ -16,9 +16,6 @@ pl:
     TEXT1: 'Oto twój'
     TEXT2: 'link zmiany hasła'
     TEXT3: dla
-  SilverStripe\Control\RequestProcessor:
-    INVALID_REQUEST: 'Nieprawidłowe żądanie'
-    REQUEST_ABORTED: 'Żądanie zostało przerwane'
   SilverStripe\Dev\DevConfirmationController:
     INFO_DESCRIPTION: 'Potwierdź potencjalnie niebezpieczną operację'
     INFO_TITLE: 'Potwierdzenie bezpieczeństwa'

lang/ru.yml

@@ -14,9 +14,6 @@ ru:
     TEXT1: 'Это ваша'
     TEXT2: 'ссылка сброса пароля'
     TEXT3: для
-  SilverStripe\Control\RequestProcessor:
-    INVALID_REQUEST: 'Неверный запрос'
-    REQUEST_ABORTED: 'Запрос отменён'
   SilverStripe\Forms\CheckboxField:
     NOANSWER: Нет
     YESANSWER: Да

lang/sk.yml

@@ -16,9 +16,6 @@ sk:
     TEXT1: 'Tu je váš'
     TEXT2: 'odkaz na resetovanie hesla'
     TEXT3: pre
-  SilverStripe\Control\RequestProcessor:
-    INVALID_REQUEST: 'Neplatná požiadavka'
-    REQUEST_ABORTED: 'Požiadavka prerušená'
   SilverStripe\Forms\CheckboxField:
     NOANSWER: Nie
     YESANSWER: Áno

lang/sl.yml

@@ -24,9 +24,6 @@ sl:
   SilverStripe\Control\Middleware\ConfirmationMiddleware\UrlPathStartswith:
     CONFIRMATION_DESCRIPTION: 'Popoln naslov URL je "{url}"'
     CONFIRMATION_NAME: 'Naslov URL se začne z "{path}"'
-  SilverStripe\Control\RequestProcessor:
-    INVALID_REQUEST: 'Neveljavni zahtevek'
-    REQUEST_ABORTED: 'Zahtevek prekinjen'
   SilverStripe\Dev\DevConfirmationController:
     INFO_DESCRIPTION: 'Potrdite potencialno škodljivo akcijo'
     INFO_TITLE: 'Varnostno preverjanje'

lang/sv.yml

@@ -16,9 +16,6 @@ sv:
     TEXT1: 'Här är din'
     TEXT2: 'återställningslänk för lösenord'
     TEXT3: för
-  SilverStripe\Control\RequestProcessor:
-    INVALID_REQUEST: 'Ogiltig förfrågan'
-    REQUEST_ABORTED: 'Förfrågan avbruten'
   SilverStripe\Forms\CheckboxField:
     NOANSWER: Nej
     YESANSWER: Ja

src/Control/Controller.php

@@ -4,10 +4,7 @@
 
 use SilverStripe\Core\ClassInfo;
 use SilverStripe\Dev\Debug;
-use SilverStripe\Dev\Deprecation;
 use SilverStripe\ORM\FieldType\DBHTMLText;
-use SilverStripe\Security\BasicAuth;
-use SilverStripe\Security\BasicAuthMiddleware;
 use SilverStripe\Security\Member;
 use SilverStripe\Security\Security;
 use SilverStripe\View\SSViewer;
@@ -62,13 +59,6 @@ class Controller extends RequestHandler implements TemplateGlobalProvider
      */
     protected $templates = [];
 
-    /**
-     * @deprecated 4.1.0:5.0.0 Add this controller's url to
-     * SilverStripe\Security\BasicAuthMiddleware.URLPatterns injected property instead of setting false
-     * @var bool
-     */
-    protected $basicAuthEnabled = true;
-
     /**
      * The response object that the controller returns.
      *
@@ -106,11 +96,6 @@ public function __construct()
      */
     protected function init()
     {
-        // @todo This will be removed in 5.0 and will be controlled by middleware instead
-        if ($this->basicAuthEnabled) {
-            BasicAuth::protect_site_if_necessary();
-        }
-
         // This is used to test that subordinate controllers are actually calling parent::init() - a common bug
         $this->baseInitCalled = true;
     }
@@ -523,19 +508,6 @@ public function render($params = null)
         return $template->process($obj);
     }
 
-    /**
-     * Call this to disable site-wide basic authentication for a specific controller. This must be
-     * called before Controller::init(). That is, you must call it in your controller's init method
-     * before it calls parent::init().
-     *
-     * @deprecated 4.1.0 Add this controller's url to SilverStripe\Security\BasicAuthMiddleware.URLPatterns injected property instead
-     */
-    public function disableBasicAuth()
-    {
-        Deprecation::notice('4.1.0', 'Add this controller\'s url to SilverStripe\Security\BasicAuthMiddleware.URLPatterns injected property instead');
-        $this->basicAuthEnabled = false;
-    }
-
     /**
      * Returns the current controller.
      *

src/Control/CookieJar.php

@@ -2,7 +2,6 @@
 
 namespace SilverStripe\Control;
 
-use SilverStripe\Dev\Deprecation;
 use SilverStripe\ORM\FieldType\DBDatetime;
 use LogicException;