Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPLinting failure #11325

Closed
GuySartorelli opened this issue Aug 6, 2024 · 0 comments
Closed

PHPLinting failure #11325

GuySartorelli opened this issue Aug 6, 2024 · 0 comments
Assignees

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Aug 6, 2024

https://github.com/silverstripe/silverstripe-framework/actions/runs/10259483412/job/28384030623?pr=11324

There's three cases of the following error which was introduced in silverstripe/silverstripe-standards#5

Can't determine value of first argument to _t(). Use a simpler value.

The rule is correct to highlight this - in most cases not being able to determine the value is bad, and we should be alerted to it.
In these three cases, the value has to be dynamic, so we need to ignore the rule for these three instances.

PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants