PHPStan rule to catch bad translation keys

[GuySartorelli]

Description

It's far too easy to make mistakes when writing translation keys for localisable strings, e.g. missing out the period between the class name and the unique key.

e.g:

_t(__CLASS__ . 'PERMISSIONS_CATEGORY', 'Dev permissions');

which results in:

php.SilverStripe\Dev\DevelopmentAdminPERMISSIONS_CATEGORY: 'Dev permissions'

It should be like this instead:

_t(__CLASS__ . '.PERMISSIONS_CATEGORY', 'Dev permissions');

We should write a PHPStan rule to catch these errors.

PRs

• NEW Add rule to catch malformed _t() calls #12

After merging, reassign to Guy to tag a new minor

[GuySartorelli]

PR merged and new minor tagged