ENH Do not use placeholders for int ID filters #10861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/5/no-placeholders
branch
from
b39185c
to
94438aa
Compare
emteknetnz
force-pushed
the
pulls/5/no-placeholders
branch
3 times, most recently
from
f5b0b09
to
5c213f6
Compare
emteknetnz
force-pushed
the
pulls/5/no-placeholders
branch
2 times, most recently
from
6297fb3
to
eaeba64
Compare
emteknetnz
force-pushed
the
pulls/5/no-placeholders
branch
2 times, most recently
from
3a427a5
to
676d2d4
Compare
GuySartorelli
requested changes
Jul 24, 2023
emteknetnz
force-pushed
the
pulls/5/no-placeholders
branch
2 times, most recently
from
2a17c51
to
c17ba22
Compare
GuySartorelli
requested changes
Jul 24, 2023
src/ORM/Filters/ExactMatchFilter.php
Outdated
| private function usePlaceholders(string $column, array $values): bool | ||
| { | ||
| if ($this->config()->get('use_placeholders_for_integer_ids') | ||
| || !preg_match('#^"(.+)"."(.+)"$#', $column, $matches)) { |
There was a problem hiding this comment.
It's obviously doing more than just getting that value, since we're explicitly saying to use placeholders if the regex doesn't match. What scenarios will there be a column that doesn't match that pattern that we're 'protecting' against?
does this PR handle filtering against "MyRelation.ID"?
|
@GuySartorelli I added more explanation |
emteknetnz
force-pushed
the
pulls/5/no-placeholders
branch
from
c17ba22
to
62542ed
Compare
GuySartorelli
requested changes
Jul 25, 2023
There was a problem hiding this comment.
Works well locally.
Just one more test scenario to add please.
I've also created a separate but related issue: #10887
emteknetnz
force-pushed
the
pulls/5/no-placeholders
branch
from
62542ed
to
6723968
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #10860
Quering time on SC hosting doing a
->filter['ID' => $ids]with 10,000 records - pretty consistent with initial laptop testing in parent issue where it's roughly 3x faster with placeholders turned offPlaceholders on - avg 0.1175s
0.1378s
0.0884s
0.1123s
0.1408s
0.1080s
Placesholders off - avg 0.0348s
0.0498s
0.0232s
0.0259s
0.0550s
0.0202s