FIX Empty relations don't have extra DB calls with eager-loading #10886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/5/eagerloaded-empty-lists
branch
3 times, most recently
from
cf93d02
to
8e2a0e6
Compare
GuySartorelli
force-pushed
the
pulls/5/eagerloaded-empty-lists
branch
from
8e2a0e6
to
68c1e35
Compare
GuySartorelli
commented
Aug 3, 2023
| @@ -1101,7 +1107,7 @@ private function fetchEagerLoadRelations(Query $query): void | |||
| $relationDataClass, | |||
| implode('.', $chainToDate), | |||
| $relationName, | |||
| $parentRelationName | |||
There was a problem hiding this comment.
The $parentRelationName argument was never used - in fact there wasn't even a parameter for it
GuySartorelli
commented
Aug 3, 2023
Comment on lines
+1436
to
+1439
| case 'has_one': | ||
| $dummyData = Injector::inst()->create($relationDataClass); | ||
| break; |
There was a problem hiding this comment.
has_one isn't used currently (see the comment about why it's not necessary in fetchEagerLoadHasOne()), but it's here for the sake of completion. It is technically valid to pass in here, and shouldn't throw an exception if we do for some reason pass it in.
GuySartorelli
force-pushed
the
pulls/5/eagerloaded-empty-lists
branch
2 times, most recently
from
2c1f09c
to
fe1cf44
Compare
emteknetnz
requested changes
Aug 3, 2023
GuySartorelli
force-pushed
the
pulls/5/eagerloaded-empty-lists
branch
from
fe1cf44
to
c19ef77
Compare
GuySartorelli
force-pushed
the
pulls/5/eagerloaded-empty-lists
branch
from
c19ef77
to
aff4ee7
Compare
emteknetnz
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue