Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Apply raw2xml before extension hook #11517

Merged
merged 1 commit into from
Dec 18, 2024
Merged

FIX Apply raw2xml before extension hook #11517

merged 1 commit into from
Dec 18, 2024

Conversation

emteknetnz
Copy link
Member

Issue silverstripe/.github#349

Fixes https://github.com/silverstripe/silverstripe-subsites/actions/runs/12342588552/job/34442723479#step:12:109

1) SilverStripe\Subsites\Tests\GroupSubsitesTest::testAlternateTreeTitle
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'The A Team <i>(global group)</i>'
+'The A Team &lt;i&gt;(global group)&lt;/i&gt;'

This was referenced Dec 17, 2024
Closed
Closed
Closed
@emteknetnz emteknetnz force-pushed the pulls/6.0/broken-builds2 branch from 30bb3d2 to f03e59a Compare December 17, 2024 22:45
GuySartorelli
GuySartorelli requested changes Dec 17, 2024
View reviewed changes
tests/php/ORM/HierarchyTest.php Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/6.0/broken-builds2 branch from f03e59a to 2cc77ed Compare December 17, 2024 23:48
GuySartorelli
GuySartorelli approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 69cb5ce into silverstripe:6.0 Dec 18, 2024
12 checks passed
@GuySartorelli GuySartorelli deleted the pulls/6.0/broken-builds2 branch December 18, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli