Move to travis trusty dist #7092

dhensby · 2017-06-29T09:47:18Z

#7091 but on master

tractorcow · 2017-06-29T09:47:37Z

Oh cool :D

dhensby · 2017-06-29T09:48:30Z

It looked like behat had problems too - lets see if it works on master

tractorcow · 2017-06-29T09:55:18Z

Oh no, pear again. =(

dhensby · 2017-06-29T09:59:49Z

Selenium doesn't seem to be working either :/

dhensby · 2017-06-29T10:03:09Z

pear install seems fine

tractorcow · 2017-06-29T10:21:41Z

If you push to the open-sourcerer fork, you'll get artifacts upload to aws. Then you can download selenium.log.

tractorcow · 2017-06-29T10:23:31Z

Ok, I've re-enabled travis and added you with write permissions to https://github.com/open-sausages/silverstripe-framework

dhensby · 2017-06-29T11:28:57Z

gah - I'm not sure I have the motivation to look into this. the speed improvements on trusty look variable at best...

I think I'll have more luck trying to get selenium running on a local trusty vm first

tractorcow · 2017-06-30T01:03:45Z

I've found that there are some additional behat breakages caused by a recent release of php-webdriver module.

Fix is at instaclick/php-webdriver#79

dhensby · 2017-06-30T12:52:20Z

still no luck

tractorcow · 2017-07-02T22:00:42Z

Errors remind me why I stopped using pear. Try composer-install instead?

dhensby · 2017-07-03T11:09:24Z

the behat tests not running are really the big issue here, but I've pushed an attempted fix to use composer to install codesniffer

dhensby · 2017-07-05T10:51:00Z

I've tried to get selenium running on a local trust vm and can't - so I'm going to bail at this point. If anyone has any ideas of how to fix this on travis, then please take a look, otherwise I'll close this.

dhensby · 2017-07-19T16:57:57Z

@chillu do you have any interest in investigating the selenium issues?

tractorcow · 2017-07-20T00:30:29Z

composer.json

@@ -94,8 +95,8 @@
        "thirdparty/"
    ],
    "scripts": {
-        "lint": "phpcs src/ tests/php",
-        "lint-clean": "phpcbf src/ tests/php",
+        "lint": "vendor/bin/phpcs src/ tests/php",


This isn't going to work if framework isn't root, meaning these scripts are no longer useful to devs. Can you set the $PATH alias to vendor/bin instead in .travis.yml?

tractorcow · 2017-09-06T02:53:41Z

Selenium is falling apart on our build, so I'm triaging and milestoning this for 4.0 stable.

I've also raised sveneisenschmidt/selenium-server-standalone#30

tractorcow · 2017-09-06T03:03:28Z

Looks like we need to install geckodriver to get support for firefox... I'll try to set this up before I dismiss the possibility immediately. :)

tractorcow · 2017-09-06T03:11:01Z

Latest ESR is 52 of firefox.... we may need to lock our expected browser requirements to that (currently it's requesting v 9!)


  ┌─ @BeforeScenario # SilverStripe\Framework\Tests\Behaviour\FeatureContext::before()
  │
  ╳  Could not open connection: TypeError: Given browserVersion [object String] "9", but current version is [object String] "55.0.3"
  ╳  Build info: version: '3.5.3', revision: 'a88d25fe6b', time: '2017-08-29T12:54:15.039Z'

dhensby · 2017-09-06T12:24:08Z

OK - I've rerun the suite and it's still failing - I'm just at the point where I'm not really sure how to proceed... @tractorcow do you want to take it on from here?

tractorcow · 2017-09-07T02:08:04Z

Yep I'm still working on it... there is quite a bit left to do (E.g. setup geckdriver, mink configuration upgrades)

tractorcow · 2017-09-07T04:41:49Z

It looks like this could be the cause of recent failures on travis precise dist:

With all incoming jobs defaulted to dist: trusty, the remaining transition we will be
focusing on is phasing out our container-based infrastructure for dist: precise jobs.
This rollout will be similar to the dist: trusty defaulting, but instead of setting a
default value, we will begin ignoring sudo: false when we find an explicit
dist: precise.

From https://blog.travis-ci.com/

dhensby · 2017-09-07T12:26:24Z

what a pain :/

tractorcow · 2017-09-08T02:08:29Z

New issue, https://github.com/instaclick/php-webdriver doesn't work with selenium 3.

tractorcow · 2017-09-08T02:30:00Z

My next step would be to fork MinkSelenium2Driver module and update support for selenium3. Not going to do that now though; Maybe next hackday?

tractorcow · 2017-09-08T02:56:24Z

I've setup a fork for working:

{
    "name": "silverstripe/installer",
    "type": "silverstripe-recipe",
    "description": "The SilverStripe Framework Installer",
    "require": {
        "php": ">=5.6.0",
        "silverstripe/recipe-plugin": ">=0.1@dev <1.0",
        "silverstripe/recipe-cms": "1.0.x-dev",
        "silverstripe-themes/simple": "~3.2.0",
        "silverstripe/serve": "dev-master",
        "se/selenium-server-standalone": "3.5.3",
        "behat/mink-selenium2-driver": "2.0.x-dev",
        "silverstripe/behat-extension": "3.1.x-dev"
    },
    "repositories": [
        {
            "type": "vcs",
            "url": "git@github.com:open-sausages/MinkSelenium2Driver.git"
        },
        {
            "type": "vcs",
            "url": "git@github.com:open-sausages/silverstripe-behat-extension.git"
        }
    ]
}

tractorcow · 2017-09-08T04:57:20Z

My progress on upgrading to facebook webdriver:

chillu · 2017-09-11T04:24:08Z

Just getting my head around this - here's the chain of events as far as I can tell:

Travis limited precise support (removed sudo:false), need to move to trusty. Travis will remove precise support completely next April.
We need sudo: false to run on container-based infrastructure for fast builds (explanation). We could switch to sudo: required to stay on trusty, but that'll slow down builds
trusty doesn’t support old Firefox releases, need to move to ESR
Selenium 2 doesn't support Firefox ESR, need to update to Selenium 3
mink-selenium2-driver doesn’t support Firefox on Selenium 3, shift to Chrome?
php-webdriver doesn’t support Selenium 3, fork and fix?

@tractorcow The above is an updated version compared to what I posted on Slack.

tractorcow · 2017-09-12T00:21:05Z

It looks like some of the issues I noticed upgrading to selenium3 were my own fault; Regarding php-webdriver/php-webdriver#468, you should only need to set --enablePassThrough false when starting selenium.

tractorcow · 2017-09-12T01:22:34Z

I have most framework tests passing, but a few iframe switching bugs.

Working branches:

tractorcow · 2017-09-12T01:35:26Z

Also followed minkphp/Mink#158; The lack of this core API means having to upgrade various behat contexts to support facebook/webdriver directly (and undesirably).

See silverstripe/silverstripe-framework#7092 for context. Trying out how this will go down on Behat tests in 3.x without further changes.

See silverstripe#7092 for context.

chillu · 2017-09-12T03:25:31Z

Note that I've switched to trusty without any other changes on cms, with successful builds: https://travis-ci.org/silverstripe/silverstripe-cms/jobs/274442114

I've created PRs to do a straight-up switch to precise for framework - just to see what the actual problem is (that's not mentioned in this thread AFAICT):

3.x PR for framework: #7366
4.x PR for framework: #7367

My theory is that we just need to pin the Firefox dependency to something that still supports Selenium 2.

chillu · 2017-09-12T03:57:30Z

So those builds both fail with:

[Behat\Mink\Exception\DriverException]                                                                                         
  Exception has been thrown in "beforeScenario" hook, defined in SilverStripe\Framework\Test\Behaviour\FeatureContext::before()  
  Could not open connection: Unable to connect to host localhost on port 7055 after 45000 ms. Firefox console output:            
  nf-WARNING **: Client failed to connect to the D-BUS daemon:                                                                   
  //bin/dbus-launch terminated abnormally without any error message

3.x: https://travis-ci.org/silverstripe/silverstripe-framework/jobs/274445959
4.x: https://travis-ci.org/silverstripe/silverstripe-framework/jobs/274446637

Now I'm updating them with a pinned Firefox version (31.0, same as cms travis config) and see if that's any different.

tractorcow · 2017-09-12T05:00:48Z

More bad news, looks like upgrading to facebook/php-webdriver is blocked by php-webdriver/php-webdriver#462.

chillu · 2017-09-12T05:54:41Z

OK, both those builds have passed - so the only thing that was necessary to fix this (apart from switching to trusty in the first place) was pinning of the FIrefox version we already had on CMS.

Selenium states that it's supporting the current Firefox ESR - which would be v52 at the moment. I haven't seen any notice about Selenium 2 being unsupported (nothing mentioned in the announcement). It'll become increasingly infeasible to stay on Selenium 2, but looks like we don't have an immediate problem there.

There's a PoC with Behat/Mink in Chrome Headless, which is said to be 3x as fast as the equivalent through Selenium - so that's promising. And it would mean we skip Selenium entirely (no longer needing Java would be nice...). I'm happy to keep going on Selenium 2 for a while and hope that someone gets to a stable version of that PoC in the meantime :D

tractorcow · 2017-09-12T07:33:17Z

Replaced with #7367

dhensby force-pushed the pulls/4/trusty-travis branch from b8dbb60 to a2f6706 Compare June 30, 2017 12:32

dhensby force-pushed the pulls/4/trusty-travis branch from a2f6706 to 309757b Compare July 3, 2017 11:08

dhensby force-pushed the pulls/4/trusty-travis branch 2 times, most recently from 1797d33 to 3dfbcd6 Compare July 3, 2017 12:48

dhensby mentioned this pull request Jul 5, 2017

Update Selenium dependency silverstripe/silverstripe-behat-extension#137

Closed

9 tasks

dhensby changed the base branch from master to 4 July 19, 2017 16:59

dhensby force-pushed the pulls/4/trusty-travis branch from 3dfbcd6 to c6858ae Compare July 19, 2017 17:04

tractorcow reviewed Jul 20, 2017

View reviewed changes

dhensby force-pushed the pulls/4/trusty-travis branch 2 times, most recently from b02374a to 118dd37 Compare July 20, 2017 10:13

dhensby mentioned this pull request Jul 20, 2017

TEST Make travis install codesniffer with composer global #7193

Merged

dhensby force-pushed the pulls/4/trusty-travis branch 5 times, most recently from ce3178c to ba1a354 Compare July 21, 2017 15:44

tractorcow added this to the Recipe 4.0.0 milestone Sep 6, 2017

tractorcow self-assigned this Sep 7, 2017

chillu added a commit to chillu/silverstripe-cms that referenced this pull request Sep 12, 2017

Switch to trusty dist on travis

91e0319

See silverstripe/silverstripe-framework#7092 for context. Trying out how this will go down on Behat tests in 3.x without further changes.

chillu mentioned this pull request Sep 12, 2017

Switch to trusty dist on travis silverstripe/silverstripe-cms#1962

Closed

chillu added a commit to chillu/silverstripe-framework that referenced this pull request Sep 12, 2017

Move to travis trusty dist

7ea7d22

See silverstripe#7092 for context.

chillu mentioned this pull request Sep 12, 2017

Move to travis trusty dist (3.x) #7366

Closed

chillu added a commit to chillu/silverstripe-framework that referenced this pull request Sep 12, 2017

Move to travis trusty dist

81097f3

See silverstripe#7092 for context.

chillu mentioned this pull request Sep 12, 2017

Move to travis trusty dist #7367

Merged

tractorcow closed this Sep 12, 2017

dhensby deleted the pulls/4/trusty-travis branch September 12, 2017 12:14

Move to travis trusty dist #7092

Move to travis trusty dist #7092

Conversation

dhensby commented Jun 29, 2017

tractorcow commented Jun 29, 2017

dhensby commented Jun 29, 2017

tractorcow commented Jun 29, 2017

dhensby commented Jun 29, 2017

dhensby commented Jun 29, 2017

tractorcow commented Jun 29, 2017

tractorcow commented Jun 29, 2017

dhensby commented Jun 29, 2017

tractorcow commented Jun 30, 2017

dhensby commented Jun 30, 2017

tractorcow commented Jul 2, 2017 • edited Loading

dhensby commented Jul 3, 2017

dhensby commented Jul 5, 2017

dhensby commented Jul 19, 2017

tractorcow Jul 20, 2017 • edited Loading

Choose a reason for hiding this comment

dhensby Jul 20, 2017

Choose a reason for hiding this comment

tractorcow commented Sep 6, 2017 • edited Loading

tractorcow commented Sep 6, 2017

tractorcow commented Sep 6, 2017 • edited Loading

dhensby commented Sep 6, 2017

tractorcow commented Sep 7, 2017

tractorcow commented Sep 7, 2017 • edited Loading

dhensby commented Sep 7, 2017

tractorcow commented Sep 8, 2017

tractorcow commented Sep 8, 2017

tractorcow commented Sep 8, 2017

tractorcow commented Sep 8, 2017

chillu commented Sep 11, 2017

tractorcow commented Sep 12, 2017

tractorcow commented Sep 12, 2017 • edited Loading

tractorcow commented Sep 12, 2017

chillu commented Sep 12, 2017

chillu commented Sep 12, 2017

tractorcow commented Sep 12, 2017

chillu commented Sep 12, 2017

tractorcow commented Sep 12, 2017

tractorcow commented Jul 2, 2017 •

edited

Loading

tractorcow Jul 20, 2017 •

edited

Loading

tractorcow commented Sep 6, 2017 •

edited

Loading

tractorcow commented Sep 6, 2017 •

edited

Loading

tractorcow commented Sep 7, 2017 •

edited

Loading

tractorcow commented Sep 12, 2017 •

edited

Loading