Symfony process constructor fix #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #311 |
emteknetnz
approved these changes
Feb 18, 2022
emteknetnz
pushed a commit
to creative-commoners/silverstripe-fulltextsearch
that referenced
this pull request
Feb 18, 2022
* FIX: silverstripe#311 Update Symfony process to at least 3.4 * FIX Separate out all command components so Solr_Reindex works in dev mode. Co-authored-by: Kirk Mayo <kirk.mayo@stats.govt.nz> Co-authored-by: GuySartorelli <36352093+GuySartorelli@users.noreply.github.com>
emteknetnz
added a commit
that referenced
this pull request
Feb 18, 2022
* FIX: #311 Update Symfony process to at least 3.4 * FIX Separate out all command components so Solr_Reindex works in dev mode. Co-authored-by: Kirk Mayo <kirk.mayo@stats.govt.nz> Co-authored-by: GuySartorelli <36352093+GuySartorelli@users.noreply.github.com> Co-authored-by: Kirk Mayo <textagroup@gmail.com> Co-authored-by: Kirk Mayo <kirk.mayo@stats.govt.nz> Co-authored-by: GuySartorelli <36352093+GuySartorelli@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests bumps the symfony/process minimum version from 3.2 to 3.4 which allows the commandline param to be a array or a string.
Also implements fixes from @GuySartorelli