Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Don't use deprecated API #345

Conversation

GuySartorelli
Copy link
Member

Deprecation::notification_version() is deprecated - we shouldn't be calling it.
There's a _config directory so we don't need to keep an empty _config.php file.

Issue

Copy link

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxime-rainville maxime-rainville merged commit d75925c into silverstripe:3.12 Mar 27, 2023
@maxime-rainville maxime-rainville deleted the pulls/3.12/no-deprecations branch March 27, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants