Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge up asset-admin test into 3.2 #250

Conversation

maxime-rainville
Copy link
Contributor

Follow up from #249

.travis.yml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
.travis.yml Outdated
- SS_BASE_URL="http://localhost:8080/"
- SS_ENVIRONMENT_TYPE="dev"
- BEHAT_RECIPE_CMS_VERSION=4.4.x-dev
- ASSET_ADMIN_VERSION=1.4.x-dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be 1.4 or 1.5?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You were looking at the older commit that was targeting the 3.1 branch I think.

@maxime-rainville maxime-rainville force-pushed the pulls/3.2/merge-up-asset-admin-tests branch from 5e0d9ba to f5c1ba8 Compare February 26, 2020 00:32
Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@maxime-rainville maxime-rainville force-pushed the pulls/3.2/merge-up-asset-admin-tests branch from f5c1ba8 to 20ee8b6 Compare February 26, 2020 01:00
@maxime-rainville maxime-rainville force-pushed the pulls/3.2/merge-up-asset-admin-tests branch from 20ee8b6 to aceefd3 Compare February 26, 2020 01:38
@maxime-rainville
Copy link
Contributor Author

Grrrr !!! Garion merge is 7.4 test before I managed to sneak this one in.

@codecov
Copy link

codecov bot commented Feb 27, 2020

Codecov Report

❗ No coverage uploaded for pull request base (3.2@eada708). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             3.2     #250   +/-   ##
======================================
  Coverage       ?   85.93%           
  Complexity     ?      969           
======================================
  Files          ?       61           
  Lines          ?     2446           
  Branches       ?        0           
======================================
  Hits           ?     2102           
  Misses         ?      344           
  Partials       ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eada708...92e64a7. Read the comment docs.

@maxime-rainville maxime-rainville merged commit 731242d into silverstripe:3.2 Feb 27, 2020
@maxime-rainville maxime-rainville deleted the pulls/3.2/merge-up-asset-admin-tests branch February 27, 2020 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants