Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: add result to onAfterMiddlware hook #258

Merged

Conversation

unclecheese
Copy link

Needed for snapshots, and seems like it could be useful in other contexts.

@unclecheese unclecheese closed this Apr 8, 2020
@unclecheese unclecheese reopened this Apr 8, 2020
@codecov
Copy link

codecov bot commented Apr 8, 2020

Codecov Report

Merging #258 into 3.2 will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##                3.2     #258   +/-   ##
=========================================
  Coverage     85.93%   85.93%           
  Complexity      969      969           
=========================================
  Files            61       61           
  Lines          2446     2446           
=========================================
  Hits           2102     2102           
  Misses          344      344           
Impacted Files Coverage Δ Complexity Δ
src/Manager.php 80.32% <100.00%> (ø) 76.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 731242d...e61889e. Read the comment docs.

@unclecheese unclecheese merged commit bee37b7 into silverstripe:3.2 Apr 8, 2020
@unclecheese unclecheese deleted the pulls/3.2/add-result-param branch April 8, 2020 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants