NEW: Stateless plugins, plugin registry as simple list #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chillu
requested changes
Nov 20, 2020
unclecheese
force-pushed
the
4
branch
2 times, most recently
from
e6199a3 to
09f1f49
Compare
chillu
approved these changes
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a number of errors that could come up when doing multiple schema builds where plugin state was polluted by preceding schemas. Plugins are no longer singletons, and are instead instantiated each time they are used. State that should be persisted for the duration of the build should be in static members, namespaced by the current schema.
Interdependent PRs