Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Make trailing parameter optional to resolve deprecation #347

Merged
merged 3 commits into from
Jan 13, 2021
Merged

FIX Make trailing parameter optional to resolve deprecation #347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
727f20d
FIX Make trailing parameter optional to resolve deprecation
Jan 11, 2021
fc667df
MNT Correct dependencies for CI
Jan 11, 2021
efecaa2
MNT Pin frameworktest requirement in CI config
Jan 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ before_script:
- if [[ (! $BEHAT_TEST) && (! $ASSETADMIN_TEST) ]]; then composer require --prefer-dist --no-update silverstripe/recipe-core:4.x-dev silverstripe/assets:1.x-dev --prefer-dist ; fi
- if [[ $DB == PGSQL ]]; then composer require silverstripe/postgresql:2.x-dev --prefer-dist --no-update; fi
- if [[ $ASSETADMIN_TEST ]]; then composer require silverstripe/recipe-cms $RECIPE_CMS_VERSION --prefer-source --no-update ; fi
- if [[ $BEHAT_TEST ]]; then composer require silverstripe/recipe-testing:^2 silverstripe/recipe-cms:$RECIPE_CMS_VERSION silverstripe/frameworktest:dev-master --prefer-source --no-update ; fi
- if [[ $BEHAT_TEST ]]; then composer require silverstripe/recipe-testing:^1 silverstripe/recipe-cms:$RECIPE_CMS_VERSION silverstripe/frameworktest:0.2.0 --prefer-source --no-update ; fi
- composer update

- if [[ $BEHAT_TEST ]]; then mkdir artifacts; fi
Expand Down
2 changes: 1 addition & 1 deletion src/Schema/DataObject/CreateCreator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public function createOperation(
public static function resolve(array $resolverContext = []): Closure
{
$dataClass = $resolverContext['dataClass'] ?? null;
return function ($obj, $args = [], $context = [], ResolveInfo $info) use ($dataClass) {
return function ($obj, $args = [], $context = [], ResolveInfo $info = null) use ($dataClass) {
if (!$dataClass) {
return null;
}
Expand Down