BUGFIX: Allow Enum fields in input types #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
requested changes
Oct 31, 2021
There was a problem hiding this comment.
Looks good
Couple of small things re failing travis tests:
- could you bump the minimum version in .travis.yml to 7.3 - https://app.travis-ci.com/github/silverstripe/silverstripe-graphql/jobs/545898894
- "config contains invalid keys: modelConfig" - I feel like this has come up before, though I'm not sure what the solution was - https://app.travis-ci.com/github/silverstripe/silverstripe-graphql/jobs/545898899
|
@emteknetnz The build is failing because the wrong version of framework test is being used. The 0.4 release uses the correct config. https://github.com/silverstripe/silverstripe-frameworktest/releases/tag/0.4.2 Do we need to update recipe-testing? |
|
Looks like the version of framework test is a variable now? https://app.travis-ci.com/github/silverstripe/silverstripe-graphql/jobs/546767496#L421 I'm kind of confused how the new travis setup works. Could use your advice. :) |
unclecheese
force-pushed
the
pulls/master/enummy-nummy-in-my-tummy
branch
from
fc7da41 to
f8dcfe3
Compare
unclecheese
force-pushed
the
pulls/master/enummy-nummy-in-my-tummy
branch
from
f8dcfe3 to
91bba54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from the DBFieldTypes work. Resolves #405