Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: change graphql codegen dir, force clear #423

Merged

Conversation

unclecheese
Copy link

  • Change .graphql/ to .graphql-codegen/
  • Force clear = 1 because the new dir will hose your build without that. Caching is unreliable anyway.

@michalkleiner
Copy link
Contributor

The folder name is better with something added to it, but it's not clear whether it generates something or whether it is generated, so how about .graphql-generated or .gql-code-generated or similar?

Happy to have clear=1 as the default.

@unclecheese unclecheese force-pushed the pulls/master/feeling-dir-ty branch from 7dfaf3c to 3bad835 Compare December 21, 2021 03:04
@unclecheese
Copy link
Author

.graphql-generated it is!

@unclecheese unclecheese merged commit f06d9e6 into silverstripe:master Dec 23, 2021
@unclecheese unclecheese deleted the pulls/master/feeling-dir-ty branch December 23, 2021 00:30
@michalkleiner
Copy link
Contributor

@unclecheese you probably didn't push some change here as the dir name is not the right one.

@unclecheese unclecheese restored the pulls/master/feeling-dir-ty branch December 23, 2021 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants