Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW: Bulk loader #432

Merged

Conversation

unclecheese
Copy link

@unclecheese unclecheese commented Jan 10, 2022

Resolves: #367
Docs: silverstripe/silverstripe-framework#10203

elemental: # arbitrary key to define what this set of loaders is doing
  load:
    inheritanceLoader:
      include:
        - DNADesign\Elemental\Models\BaseElement
  apply:
    fields:
      '*': true
    operations:
      read: true
      readOne: true
app:
  load:
    namespaceLoader:
      include:
        - 'App\Models\*'
      exclude:
        - 'App\Models\Secret\*'
  apply:
    fields:
      '*': true
    operations:
      '*': true

@unclecheese unclecheese force-pushed the pulls/master/the-incredible-bulk branch from 30531c8 to d8e0311 Compare January 10, 2022 23:47
@unclecheese unclecheese force-pushed the pulls/master/the-incredible-bulk branch from 6050e9d to b330ea5 Compare January 13, 2022 10:46
@unclecheese unclecheese marked this pull request as ready for review January 13, 2022 21:33
@unclecheese unclecheese changed the title WIP: Bulk loader NEW: Bulk loader Jan 14, 2022
Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some very minor things

src/Schema/BulkLoader/AbstractBulkLoader.php Outdated Show resolved Hide resolved
src/Schema/BulkLoader/AbstractBulkLoader.php Outdated Show resolved Hide resolved
src/Schema/BulkLoader/BulkLoaderSet.php Outdated Show resolved Hide resolved
src/Schema/BulkLoader/BulkLoaderSet.php Outdated Show resolved Hide resolved
src/Schema/BulkLoader/ExtensionLoader.php Outdated Show resolved Hide resolved
src/Schema/BulkLoader/FilepathLoader.php Outdated Show resolved Hide resolved
src/Schema/BulkLoader/InheritanceLoader.php Outdated Show resolved Hide resolved
src/Schema/BulkLoader/ExtensionLoader.php Outdated Show resolved Hide resolved
src/Schema/BulkLoader/ExtensionLoader.php Show resolved Hide resolved
src/Schema/Interfaces/Identifiable.php Outdated Show resolved Hide resolved
@unclecheese unclecheese force-pushed the pulls/master/the-incredible-bulk branch from 6db4508 to f625fb1 Compare January 20, 2022 04:56
@unclecheese unclecheese merged commit 191ac40 into silverstripe:master Jan 20, 2022
@unclecheese unclecheese deleted the pulls/master/the-incredible-bulk branch January 20, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants