Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Require a caret version of frameworktest #449

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Mar 21, 2022

Need ^0.4.3 to fix guzzle issue - https://app.travis-ci.com/github/silverstripe/silverstripe-graphql/jobs/563992053#L481

Not including frameworktest in composer.json because it's running behat tests in the asset-admin module, not on the graphql module

Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxime-rainville maxime-rainville merged commit 608c8d8 into silverstripe:3.7 Mar 22, 2022
@maxime-rainville maxime-rainville deleted the pulls/3.7/travis-frameworktest branch March 22, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants