API Strongly type everything

[maxime-rainville]

Trying to strongly type everything.

Parent issue

• Prep GraphQL v4 for beta #455

[GuySartorelli]

In some cases you've removed the params and returns from phpdoc blocks and in other cases you e retained it. We should be consistent about that (and probably have at least a semiformal policy about it to make it easier on ourselves when it comes time to strongly type other modules)

[maxime-rainville]

I try to strongly type everything.

There's a few places where array definition where clearly meant to be callabale so I swapped those.

When the PHPDoc was just repeating the explicit types, I removed it.

[maxime-rainville]

I couldn't find this being used anywhere.

[maxime-rainville]

Couldn't find this being used anywhere.

[GuySartorelli]

I haven't gone through the whole PR 'cause it's pretty big - there's a lot of inconsistency about keeping or removing @param and @returns declarations in PHPDocs even when they match the typehints exactly.

There are also a couple of other small changes here (namely some missing typehints) - but again I haven't checked the whole PR much less had a hunt around outside the diff to see if there were others missed out.

[maxime-rainville]

Just pushed a few extra changes to explicitly require all the libraries directly reference in the codebase and to make Versioned optional.

[GuySartorelli]

You've still got a lot of PHPDocs here that are duplicating (and in at least one case in conflict with) the strong param and/or return types. I'm not going to go through and ping them all in the review because you'll still have to go through and find them all in your IDE to remove them, so it's just duplication of effort.
Consider this a blanket "Please remove the PHPDocs param and return declarations that are the same as the strong typehints, and validate any that are in conflict.

[GuySartorelli]

Still a lot of types mentioned in PHPDocs. I've gone through and tagged them this time.
Note that in some cases it's possible that removing just the bits I've pinged will result in an empty PHPDoc - in those cases the whole PHPDoc should be thrown out.

I did find some missing types (see comments)

There's also a question in here about typing callables as array.

[GuySartorelli]

Suggested change

	* @param int $timeout
	* @return null|string

Also remove the url param phpdoc.

[GuySartorelli]

Looks good to me. A few phpdocs missed but we've agreed over slack that some redundant phpdocs here or there isn't the end of the world, and shouldn't block this PR being merged.

Merge on green.

[GuySartorelli]

Behat failure is on master already, so not related to this PR.