FIX Handle missing tables in postgres on flush #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 6, 2022
emteknetnz
force-pushed
the
pulls/3.7/postgres-flush
branch
from
608e863 to
78749eb
Compare
emteknetnz
force-pushed
the
pulls/3.7/postgres-flush
branch
2 times, most recently
from
91ff9f0 to
5fc5a8c
Compare
emteknetnz
force-pushed
the
pulls/3.7/postgres-flush
branch
from
5fc5a8c to
dff7d5d
Compare
GuySartorelli
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/gha-ci#11
Example https://github.com/creative-commoners/silverstripe-admin/runs/7194459625?check_suite_focus=true
Fixes postgres missing table errors on flush - meaning it's OK to have a missing table when graphql runs flush. Currently MySQL works fine with this, though the error message from postgres does not seem to be on the bottom line of the message, so this PR makes it so the whole message is scanned.
Targeting 3.7 as that's what's used by recipe-cms 4.10, which is the lowest version github actions ci is targeting
Note: travis failure is due to it being unable to no longer run on anything but the latest minor version because it trys to use installer 4.11.x-dev, which is not compatible with this old version of graphql 3.7
CI run is instead done here - emteknetnz#2