MNT Fix unit test #619
Merged
MNT Fix unit test #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/5.2/broken-builds
branch
from
0ffb6ca to
f8d218f
Compare
emteknetnz
commented
Dec 18, 2024
emteknetnz
force-pushed
the
pulls/5.2/broken-builds
branch
2 times, most recently
from
d49c216 to
946b3be
Compare
emteknetnz
force-pushed
the
pulls/5.2/broken-builds
branch
from
946b3be to
9141779
Compare
|
Behat CI failures are unrelated - see https://github.com/silverstripe/silverstripe-graphql/actions/runs/12405960397/job/34633657098 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/.github#349
Fixes https://github.com/silverstripe/recipe-kitchen-sink/actions/runs/12402341307/job/34623934194#step:12:115 where it seems that a utf space is used after a change in operating system, or operating system dependency that github actions uses
Solution copied from https://github.com/silverstripe/silverstripe-framework/pull/11409/files#diff-7ee4a8bc9e331e2692dc3e5b3c4827a84b8259878698ee68555490346af34ef7R51