Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Fix scss lint warnings #289

Merged
merged 1 commit into from
Jun 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .stylelintignore

This file was deleted.

2 changes: 1 addition & 1 deletion client/dist/styles/main.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion client/src/styles/bundle.scss
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
// Variables (from silverstripe/admin)
@import "variables";

@import "./manager";
@import "./managerBulkEditingForm";
@import "./uploader";
9 changes: 1 addition & 8 deletions client/src/styles/manager.scss
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
min-width: 120px;
}

/* stylelint-disable-next-line selector-max-compound-selectors */
.chosen-container-single .chosen-single
{
border-top-right-radius: 0;
Expand All @@ -67,7 +68,6 @@
float: left;
border-top-left-radius: 0;
border-bottom-left-radius: 0;

height: 36px;
line-height: 26px;
margin-left: -1px;
Expand All @@ -91,13 +91,10 @@
float: left;
clear: none;
max-width: 100%;

margin: 0;
padding: 0 1.25rem;

height: 36px;
line-height: 34px;

opacity: 0;
overflow: auto;

Expand All @@ -111,10 +108,6 @@
opacity: 1;
}
}

.bulkSelectAll
{
}
}
}// .bulkManagerOptions

Expand Down
26 changes: 5 additions & 21 deletions client/src/styles/managerBulkEditingForm.scss
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,7 @@
{
float: left;
width: 70%;

margin: 40px 0 20px 0;

margin: 40px 0 20px;
font-size: 30px;
font-weight: bold;
}
Expand All @@ -15,9 +13,7 @@
float: right;
clear: right;
width: 25%;

margin: 40px 0 20px 0;

margin: 40px 0 20px;
text-decoration: underline;
text-align: right;
cursor: pointer;
Expand All @@ -32,13 +28,7 @@
&.hasUpdate .ui-accordion-header
{
background-color: #f2ba11;

background-image: -webkit-gradient(linear, 50% 0%, 50% 100%, color-stop(0%, #f2ba11), color-stop(100%, #df6e00));
background-image: -webkit-linear-gradient(top, #f2ba11 0%, #df6e00 100%);
background-image: -moz-linear-gradient(top, #f2ba11 0%, #df6e00 100%);
background-image: -o-linear-gradient(top, #f2ba11 0%, #df6e00 100%);
background-image: -ms-linear-gradient(top, #f2ba11 0%, #df6e00 100%);
background-image: linear-gradient(top, #f2ba11 0%, #df6e00 100%);
background-image: linear-gradient(to top, #f2ba11 0%, #df6e00 100%);

a
{
Expand All @@ -50,18 +40,12 @@
&.updated .ui-accordion-header
{
background-color: #a4ca3a;

background-image: -webkit-gradient(linear, 50% 0%, 50% 100%, color-stop(0%, #a4ca3a), color-stop(100%, #59781D));
background-image: -webkit-linear-gradient(top, #a4ca3a 0%, #59781D 100%);
background-image: -moz-linear-gradient(top, #a4ca3a 0%, #59781D 100%);
background-image: -o-linear-gradient(top, #a4ca3a 0%, #59781D 100%);
background-image: -ms-linear-gradient(top, #a4ca3a 0%, #59781D 100%);
background-image: linear-gradient(top, #a4ca3a 0%, #59781D 100%);
background-image: linear-gradient(to top, #a4ca3a 0%, #59781D 100%);

a
{
color: #fff;
text-shadow: none;
}
}
}
}
2 changes: 1 addition & 1 deletion client/src/styles/uploader.scss
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
{
.uploadfield__droptext
{
&::before
&:before
{
text-transform: none;
content: "b";
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@
"watch": "NODE_ENV=development webpack --watch --progress",
"css": "WEBPACK_CHILD=css npm run build",
"tx": "tx push --source && tx pull --all && node transifex.js",
"lint": "eslint client/src && yarn lint-sass",
"lint": "yarn lint-js && yarn lint-sass",
"lint-js": "eslint client/src",
"lint-js-fix": "eslint client/src --fix",
"lint-sass": "stylelint **/client/src/**/*.scss"
"lint-sass": "stylelint client/src"
},
"repository": {
"type": "git",
Expand Down
Loading