Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency: SAML helper transforms binary guid to upper-case #21

Open
JakubDolba opened this issue Jun 13, 2019 · 0 comments
Open

Inconsistency: SAML helper transforms binary guid to upper-case #21

JakubDolba opened this issue Jun 13, 2019 · 0 comments

Comments

@JakubDolba
Copy link
Contributor

\SilverStripe\SAML\Helpers\SAMLHelper::binToStrGuid
is converting GUID to uppercase after binary conversion

  • but this applies only for option expect_binary_nameid = true
  • other options will use value from SAML as it was received (lowercase most likely)

there are related issues with that: #17 and #20
also there is pull request to normalize GUID before usage but there is still inconsistency in behavior ( #18 -> solve #17 )

expectation:
consistent behavior (one of upper or lower case guid) should be default for all options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant