Add: GUID Transformation #18
Conversation
JakubDolba
force-pushed
the
feature/guid-transformation-callback
branch
from
293a588 to
6c05344
Compare
src/Control/SAMLController.php
Outdated
| @@ -147,6 +147,11 @@ public function acs() | |||
| $guid = $auth->getNameId(); | |||
| } | |||
|
|
|||
| $guidTransformation = Config::inst()->get(SAMLConfiguration::class, 'guid_transformation_callable'); | |||
| if ($guidTransformation !== null) { | |||
| $guid = $guidTransformation($guid); | |||
There was a problem hiding this comment.
Nice idea. How would you feel about adding an extension point instead? E.g. $this->updateGuid($guid) then extensions can call strtoupper() if they want to.
There was a problem hiding this comment.
was thinking about that but this means you have to actually create extension and do something in code
typical use-case for this is simple upper/lower case so I thought that simple callable as string is much more simpler for that (ie. you don't need tuch code by using simple callable string)
There was a problem hiding this comment.
That's true. The difference is where you place the burden of maintenance - either on user code or in this module. Generally we place that burden on project or module developers which keeps our support footprint lighter.
There was a problem hiding this comment.
ok, if extension is prefered way how to do this...
added a fixup commit; will rebase if new commit will be ok, also I will change title and descriptions (will remove "callable")
JakubDolba
changed the title
JakubDolba
force-pushed
the
feature/guid-transformation-callback
branch
3 times, most recently
from
5782b08 to
a72a947
Compare
docs/en/developer.md
Outdated
| @@ -149,6 +150,11 @@ SilverStripe\SAML\Extensions\SAMLMemberExtension: | |||
| - 'http://schemas.xmlsoap.org/ws/2005/05/identity/claims/name': 'Email' | |||
| ``` | |||
|
|
|||
| ### GUID Transformation | |||
|
|
|||
| If you prefer received GUID in lower-case or upper-case format you can extend and overload method: | |||
There was a problem hiding this comment.
| If you prefer received GUID in lower-case or upper-case format you can extend and overload method: | |
| If you prefer to receive the GUID in lower-case or upper-case format you can use the `updateGuid()` extension point on `\SilverStripe\SAML\Control\SAMLController`. |
…bility to store guid only as lowercase for example)
JakubDolba
force-pushed
the
feature/guid-transformation-callback
branch
from
a72a947 to
7a0810c
Compare
this fixes #17
There is use-case for normalizing GUID format (upper vs. lower case) before saving GUID to Member
this functionality is adding simple callable option to change GUID format