Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP8 compatibility #40

Closed
MelissaWu-SS opened this issue Aug 2, 2022 · 1 comment
Closed

PHP8 compatibility #40

MelissaWu-SS opened this issue Aug 2, 2022 · 1 comment

Comments

@MelissaWu-SS
Copy link
Contributor

There are two packages that this module requires, zendframework/zend-session and zendframework/zend-authentication are abandoned now, and they don't support php 8. But after investigation, it is found these two packages are not actually used by the SAML module. We can just remove these two packages from the composer.json of the SAML module.

Another package that the SAML module requires, onelogin/php-saml is in ^3.0.0, it should be upgraded to the latest version 4.1.0, which supports PHP 8 well.

Upgrade the phpunit version to ^9.5 for PHP 8 compatibility.

@satrun77
Copy link
Collaborator

Fixed thanks to @UndefinedOffset version 2.1.1 released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants