Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove zend dependencies + GitHub CI #41

Merged
merged 4 commits into from
Sep 25, 2022
Merged

Remove zend dependencies + GitHub CI #41

merged 4 commits into from
Sep 25, 2022

Conversation

UndefinedOffset
Copy link
Contributor

@UndefinedOffset UndefinedOffset commented Sep 22, 2022

It looks like the Zend dependencies referenced in #31 are not actually needed, this pull request removes them and also switches to GitHub Actions for CI. Also addresses #40 by also updating the onelogin/php-saml dependency to ^4.1.0.

@UndefinedOffset UndefinedOffset changed the title Feature remove zend dependencies Remove zend dependencies + GitHub CI Sep 22, 2022
Bump min PHP version to 7.4
Copy link
Collaborator

@satrun77 satrun77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@satrun77 satrun77 merged commit 6b60607 into silverstripe:master Sep 25, 2022
@UndefinedOffset
Copy link
Contributor Author

@satrun77 any chance for a new tag? Also I notice I forgot to update the requirements in the readme it still talks about PHP 5.6 ;)

@satrun77
Copy link
Collaborator

@UndefinedOffset can you please make another PR to correct the readme file? Thanks :)

I will test the latest changes and then tag it

@satrun77
Copy link
Collaborator

@UndefinedOffset tagged 2.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants