ENH Update code to avoid calling deprecated code #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
GuySartorelli
force-pushed
the
pulls/3/deprecations-cmsmain
branch
from
e96283c to
58d9325
Compare
GuySartorelli
commented
Dec 9, 2024
| data-helpurl="https://userhelp.silverstripe.org/en/4/optional_features/share_draft_content" | ||
| data-helpurl="https://userhelp.silverstripe.org/en/optional_features/share_draft_content" |
There was a problem hiding this comment.
Not related but should be updated
GuySartorelli
commented
Dec 9, 2024
| @@ -2,7 +2,7 @@ | |||
| <%-- Placeholder is re-rendered by the ShareDraftContent React component --%> | |||
| <span class="share-draft-content__placeholder" | |||
| data-url="<% if $CurrentPage.ShareDraftLinkAction %>{$CurrentPage.ShareDraftLinkAction}<% else %>{$Controller.CurrentPage.ShareDraftLinkAction}<% end_if %>" | |||
There was a problem hiding this comment.
Note these references must not be updated to currentRecord.
CurrentPage is not actually accessing the CurrentPage() method on the LeftAndMain (or in this case CMSMainPageEditController) instance. Instead, because of how this template gets rendered, it's falling back to the global template provider $CurrentPage which calls Controller::curr().
ShareDraftLinkAction() then gets called on the controller, not on the page record.
GuySartorelli
force-pushed
the
pulls/3/deprecations-cmsmain
branch
from
58d9325 to
6a79668
Compare
emteknetnz
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
SiteTreeinCMSMainsilverstripe-cms#2947