DOC Update doc structure for docs.silverstripe.org #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
commented
May 21, 2024
There was a problem hiding this comment.
Removed the following documentation:
| section | reason |
|---|---|
| Filtering with Taxonomy Terms | Shows a pretty complex query for a very narrow use case that avoids using the ORM (so, narrow use case with arguably bad practices) |
| Taxonomy Navigation | Seems unlikely you'd want a whole page dedicated to this - you'd probably more likely just want to add this as a part of a pre-existing page. Even if you do want this, it's pretty straight forward to create a page. We'll deprecate the built in TaxonomyDirectoryController - that only works for the Page class and only when a relation with a specific name is set up, it's too narrow in purpose |
| { | ||
| $fields = parent::getCMSFields(); | ||
| // ... | ||
| $fields->addFieldToTab('Root.Main', TreeMultiselectField::create( |
There was a problem hiding this comment.
TreeMultiselectField is way more intuitive and lightweight than the old docs saying to use GridField.
GuySartorelli
force-pushed
the
pulls/3.2/update-docs
branch
from
7976347
to
fa6dfe1
Compare
Also remove unnecessary docs and add doc linting
GuySartorelli
force-pushed
the
pulls/3.2/update-docs
branch
from
fa6dfe1
to
532a3ca
Compare
4 tasks
GuySartorelli
force-pushed
the
pulls/3.2/update-docs
branch
from
ab45bc4
to
79d96a7
Compare
GuySartorelli
commented
May 21, 2024
| @@ -35,7 +36,11 @@ | |||
| "SilverStripe\\Taxonomy\\Tests\\Behat\\Context\\": "tests/behat/src/" | |||
| } | |||
| }, | |||
| "extra": [], | |||
There was a problem hiding this comment.
Removed unnecessary empty section
GuySartorelli
commented
May 21, 2024
There was a problem hiding this comment.
All changes in this file were just to pass linting.
emteknetnz
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove unnecessary docs and add doc linting
Issue