Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Use GitHub Actions CI #95

Merged
merged 1 commit into from
Jul 15, 2022
Merged

MNT Use GitHub Actions CI #95

merged 1 commit into from
Jul 15, 2022

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz mentioned this pull request Jul 5, 2022
Closed
40 tasks
@emteknetnz emteknetnz force-pushed the pulls/4.3/module-standards branch 2 times, most recently from 5da0451 to 9a2355b Compare July 6, 2022 04:28
@emteknetnz emteknetnz force-pushed the pulls/4.3/module-standards branch from 9a2355b to b7ed033 Compare July 13, 2022 22:35
GuySartorelli
GuySartorelli reviewed Jul 14, 2022
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The travis config includes SS_MFA_SECRET_KEY=TEST1231 - is that included in the new CI somewhere? Or is it not needed?

@emteknetnz
Copy link
Member Author

Added in gha-ci now - https://github.com/silverstripe/gha-ci/blob/1/.github/workflows/ci.yml#L538

@GuySartorelli GuySartorelli merged commit 9ec3b10 into silverstripe:4.3 Jul 15, 2022
@GuySartorelli GuySartorelli deleted the pulls/4.3/module-standards branch July 15, 2022 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli