ENH Update reference to supported modules data #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 8, 2024
Required both for using a correct PHP version and making sure patches get auto-tagged
GuySartorelli
commented
May 8, 2024
| "php": "^7.4 || ^8.1", | ||
| "php": "^8.1", |
There was a problem hiding this comment.
supported-modules needs 8.1
emteknetnz
requested changes
May 8, 2024
| @@ -4,30 +4,8 @@ on: | |||
| push: | |||
| pull_request: | |||
| workflow_dispatch: | |||
| # Every Tuesday at 2:00pm UTC | |||
| schedule: | |||
There was a problem hiding this comment.
We should keep the schedule? If an auto-tag fails on merge (happens very occasionally) the cron will pick it up
There was a problem hiding this comment.
Standardiser will add dispatch-ci to this module when it's next run. This is the way we do this for all repos that use standard CI.
emteknetnz
approved these changes
May 9, 2024
|
Have released 1.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs silverstripe/supported-modules#29
Also update CI to use gha-ci which is required both for using a correct PHP version and making sure patches get auto-tagged
Issues