FIX Look in new files for duplicated strings #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/1.2/check-new-files-for-en
branch
from
edfca57
to
cf7740a
Compare
GuySartorelli
commented
Aug 5, 2024
Comment on lines
+461
to
+465
| $ext = pathinfo($path, PATHINFO_EXTENSION); | ||
| $enPath = preg_replace('#/[^/\.]+\.js[a-zA-Z]*$#', '/en.' . $ext, $path); | ||
| if (!file_exists($enPath)) { | ||
| $enPath = preg_replace('#/[^/\.]+\.js[a-zA-Z]*$#', '/en.json', $path); | ||
| } |
There was a problem hiding this comment.
This is also new - userforms has their src files as *.js files, not *.json files. So check for the en file with the same ext first, then try json explicitly as a fallback,
emteknetnz
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were only looking for duplicated english strings in files that already existed - but when new files are pulled down from transifex they weren't being checked.
Issue