Skip to content

Commit

Permalink
MNT Remove TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
Sabina Talipova committed Oct 10, 2023
1 parent 071fba1 commit ab24194
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 8 deletions.
4 changes: 1 addition & 3 deletions code/Form/UserForm.php
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,7 @@ public function getFormFields()
* Generate the form actions for the UserDefinedForm. You
* can manipulate these by using {@link updateFormActions()} on
* a decorator.
*
* @todo Make form actions editable via their own field editor.
*
*
* @return FieldList
*/
public function getFormActions()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ public function getValueFromData($data)
public function getSelectorField(EditableCustomRule $rule, $forOnLoad = false)
{
// watch out for checkboxs as the inputs don't have values but are 'checked
// @todo - Test this
if ($rule->FieldValue) {
return "$(\"input[name='{$this->Name}[]'][value='{$rule->FieldValue}']\")";
} else {
Expand Down
1 change: 0 additions & 1 deletion code/Model/EditableFormField/EditableLiteralField.php
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,6 @@ public function getFormField()

$field = CompositeField::create($content)
->setName($this->Name)
// ->setID($this->Name) // @todo: https://github.com/silverstripe/silverstripe-framework/issues/7264
->setFieldHolderTemplate(__CLASS__ . '_holder');

$this->doUpdateFormField($field);
Expand Down
2 changes: 0 additions & 2 deletions code/Task/RecoverUploadLocationsHelper.php
Original file line number Diff line number Diff line change
Expand Up @@ -447,8 +447,6 @@ private function chunk($chunkSize = 100)
'"SubmittedFileFieldTable"."UploadedFileID" > ?' => $greaterThanID
])->execute();

// TODO: Versioned::prepopulate_versionnumber_cache

foreach ($chunk as $item) {
yield $item;
$greaterThanID = $item['UploadedFileID'];
Expand Down
1 change: 0 additions & 1 deletion tests/php/Model/UserDefinedFormTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ public function testRollbackToVersion()
'UserDefinedForm::rollback() has not been implemented completely'
);

// @todo
$this->logInWithPermission('ADMIN');
/** @var UserDefinedForm|Versioned $form */
$form = $this->objFromFixture(UserDefinedForm::class, 'basic-form-page');
Expand Down

0 comments on commit ab24194

Please sign in to comment.