Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH Do not call form field validate in validator #1358

Merged
merged 1 commit into from
Dec 12, 2024
Merged

ENH Do not call form field validate in validator #1358

merged 1 commit into from
Dec 12, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz mentioned this pull request Dec 11, 2024
Closed
8 tasks
@emteknetnz emteknetnz marked this pull request as ready for review December 11, 2024 20:28
GuySartorelli
GuySartorelli approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - will merge when other code PRs are mergable

@GuySartorelli GuySartorelli merged commit c076336 into silverstripe:7.0 Dec 12, 2024
11 of 14 checks passed
@GuySartorelli GuySartorelli deleted the pulls/7.0/remove-fieldsvalidator branch December 12, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli