Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Use GitHub Actions CI #365

Merged
merged 1 commit into from
Jul 5, 2022
Merged

MNT Use GitHub Actions CI #365

merged 1 commit into from
Jul 5, 2022

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Jun 29, 2022 •
edited
Loading

@emteknetnz emteknetnz force-pushed the pulls/1.10/module-standards branch from 0d9d108 to ea7bb1d Compare June 30, 2022 04:04
@emteknetnz emteknetnz closed this Jun 30, 2022
@emteknetnz emteknetnz reopened this Jun 30, 2022
@emteknetnz emteknetnz force-pushed the pulls/1.10/module-standards branch from ea7bb1d to 39c389f Compare July 4, 2022 02:38
@emteknetnz emteknetnz mentioned this pull request Jul 5, 2022
Closed
40 tasks
@GuySartorelli
Copy link
Member

GuySartorelli commented Jul 5, 2022 •
edited
Loading

Noting for the sake of visibility:
Note that the CI didn't run because there were no runners available, and the workflow isn't on the repo yet so it wasn't queued

The fact that travis didn't run is a little concerning - but ultimately benign for this PR since nothing here will affect travis.

@emteknetnz emteknetnz force-pushed the pulls/1.10/module-standards branch from 39c389f to 4bee7a0 Compare July 5, 2022 04:02
GuySartorelli
GuySartorelli approved these changes Jul 5, 2022
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis error is unrelated. GHA is green in creative-commoners.

@GuySartorelli GuySartorelli merged commit e62ad75 into silverstripe:1.10 Jul 5, 2022
@GuySartorelli GuySartorelli deleted the pulls/1.10/module-standards branch July 5, 2022 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli